criu: do not ignore errors with ret != -1

giuseppe · giuseppe · commit 4db170c5ed34 · 2026-02-10T12:58:01.000+01:00
Closes: containers#1990 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
diff --git a/src/libcrun/criu.c b/src/libcrun/criu.c
@@ -1217,7 +1217,7 @@ libcrun_container_restore_linux_criu (libcrun_container_status_t *status, libcru
     }
 out:
   ret_out = rmdir (root);
-  if (UNLIKELY (ret == -1))
+  if (UNLIKELY (ret < 0))
     return ret;
   if (UNLIKELY (ret_out == -1))
     return crun_make_error (err, errno, "error removing restore directory `%s`", root);

Original file line number	Diff line number	Diff line change
`@@ -1217,7 +1217,7 @@ libcrun_container_restore_linux_criu (libcrun_container_status_t *status, libcru`
`1217`	`1217`	`}`
`1218`	`1218`	`out:`
`1219`	`1219`	`ret_out = rmdir (root);`
`1220`		`- if (UNLIKELY (ret == -1))`
	`1220`	`+ if (UNLIKELY (ret < 0))`
`1221`	`1221`	`return ret;`
`1222`	`1222`	`if (UNLIKELY (ret_out == -1))`
`1223`	`1223`	return crun_make_error (err, errno, "error removing restore directory `%s`", root);