container: fix error leak

giuseppe · giuseppe · commit 5634cad3d9fa · 2026-01-23T12:29:31.000+01:00
print the current error and release it. Closes: containers#1957 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
diff --git a/src/libcrun/container.c b/src/libcrun/container.c
@@ -813,7 +813,10 @@ do_hooks (runtime_spec_schema_config_schema *def, pid_t pid, const char *id, boo
       if (UNLIKELY (ret != 0))
         {
           if (keep_going)
-            libcrun_warning ("error executing hook `%s` (exit code: %d)", hooks[i]->path, ret);
+            {
+              libcrun_warning ("error executing hook `%s` (exit code: %d)", hooks[i]->path, ret);
+              crun_error_release (err);
+            }
           else
             {
               libcrun_error (0, "error executing hook `%s` (exit code: %d)", hooks[i]->path, ret);

Original file line number	Diff line number	Diff line change
`@@ -813,7 +813,10 @@ do_hooks (runtime_spec_schema_config_schema def, pid_t pid, const char id, boo`
`813`	`813`	`if (UNLIKELY (ret != 0))`
`814`	`814`	`{`
`815`	`815`	`if (keep_going)`
`816`		- libcrun_warning ("error executing hook `%s` (exit code: %d)", hooks[i]->path, ret);
	`816`	`+ {`
	`817`	+ libcrun_warning ("error executing hook `%s` (exit code: %d)", hooks[i]->path, ret);
	`818`	`+ crun_error_release (err);`
	`819`	`+ }`
`817`	`820`	`else`
`818`	`821`	`{`
`819`	`822`	libcrun_error (0, "error executing hook `%s` (exit code: %d)", hooks[i]->path, ret);