Update Helper Functions, Tests, and Markdown Installation

Updated function name and tests for consistency
Improved error handling in markdown installation script
Refactored test files to use new function name
Fixed argument parsing test cases for document subcommand

Author: itlackey

src/helpers.sh

@@ -198,7 +198,7 @@ json_escape() {
 }
 
 extract_content_from_response() {
-    # Usage: extract_content "$json_string"
+    # Usage: extract_content_from_response "$json_string"
     json=$1
 
     # 1) Extract all lines from the "content" property (handles multi-line content)

src/markdown.sh

@@ -327,7 +327,7 @@ install_from_github() {
   curl -fsSL "https://github.com/charmbracelet/glow/releases/download/$tag/$file" -o "$tmpdir/glow.tar.gz"
   curl -fsSL "https://github.com/charmbracelet/glow/releases/download/$tag/checksums.txt" -o "$tmpdir/checksums.txt"
 
-  cd "$tmpdir"
+  cd "$tmpdir" || exit 1
   sha256sum -c checksums.txt --ignore-missing --quiet || {
     echo "Checksum verification failed"
     exit 1
@@ -343,7 +343,7 @@ install_from_github() {
     sudo mv glow "$bindir"
   fi
 
-  cd -
+  cd - || exit 1
   rm -rf "$tmpdir"
 
   echo "glow installed to $bindir"

tests/test_extract_content.bats

@@ -14,43 +14,43 @@ setup() {
 
 @test "extracts simple single-line content" {
     json='{"message":{"content":"Hello World"}}'
-    run extract_content "$json"
+    run extract_content_from_response "$json"
     [ "$status" -eq 0 ]
     [ "$output" = "Hello World" ]
 }
 
 @test "extracts multi-line content with \\n escapes" {
     json='{"message":{"content":"Line1\nLine2\nLine3"}}'
-    run extract_content "$json"
+    run extract_content_from_response "$json"
     [ "$status" -eq 0 ]
     expected=$'Line1\nLine2\nLine3'
     [ "$output" = "$expected" ]
 }
 
 @test "extracts content containing escaped quotes" {
     json='{"message":{"content":"He said: \"Hi there\""}}'
-    run extract_content "$json"
+    run extract_content_from_response "$json"
     assert_success
     assert_output 'He said: "Hi there"'
 }
 
 @test "extracts content with backslashes" {
     json='{"message":{"content":"Path C:\\Windows\\System32"}}'
-    run extract_content "$json"
+    run extract_content_from_response "$json"
     assert_success
     assert_output 'Path C:\Windows\System32'
 }
 
 @test "returns empty string when content key is missing" {
     json='{"foo":"bar"}'
-    run extract_content "$json"
+    run extract_content_from_response "$json"
     assert_success
     [ -z "$output" ]
 }
 
 @test "extracts content when other keys present" {
     json='{"choices":[{"foo":123,"message":{"content":"# Announcement\nUpdate complete."},"other":true}]}'
-    run extract_content "$json"
+    run extract_content_from_response "$json"
     assert_success
     expected=$'# Announcement\nUpdate complete.'
     assert_output "$expected"
@@ -59,7 +59,7 @@ setup() {
 @test "extracts content from example_response.json file" {
     json=$(cat "$BATS_TEST_DIRNAME/assets/example_response.json")
     tmp_output=$(mktemp)
-    response="$(extract_content "${json}")"
+    response="$(extract_content_from_response "${json}")"
     echo $response >"$tmp_output"
     output=$(cat "$tmp_output")
     [ -n "$output" ]

tests/test_parse_args.bats

@@ -147,7 +147,7 @@ setup_git_range() {
 }
 
 @test "subcommand 'document' is accepted and printed" {
-  run parse_args document --verbose
+  run parse_args document --verbose --prompt-file "TEST"
   assert_success
   assert_output --partial "Subcommand: document"
 }
@@ -274,12 +274,7 @@ setup_git_range() {
   assert_output --partial "Pathspec: "
 }
 
-# Insert the new test cases for the 'document' subcommand
-@test "subcommand 'document' is accepted and printed" {
-  run parse_args document --verbose --prompt-file PROMPT
-  assert_success
-  assert_output --partial "Subcommand: document"
-}
+
 
 @test "document subcommand without --prompt-file errors out" {
   run parse_args document --verbose

tests/tests.bats

@@ -387,7 +387,7 @@ EOF
 @test "Env API key required for remote" {
   unset GIV_API_KEY
   gen_commits
-  run "$GIV_SCRIPT" changelog HEAD --model-provider remote --api-url http://fake --api-model dummy
+  run "$GIV_SCRIPT" changelog HEAD --model-mode remote --api-url http://fake --api-model dummy
   assert_output --partial "GIV_API_KEY"
 }