Skip to content

Commit 2ed9e8c

Browse files
authored
Merge pull request #29 from gjanders/timer-isalive-fix
Timer isalive fix
2 parents fa3b2e3 + 0c7a5e5 commit 2ed9e8c

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,9 @@ As of October 2022, there are still no signs of version control within the Splun
326326
- [Search Head Backup](https://splunkbase.splunk.com/app/6438) - backup to an index, works in Splunk Cloud
327327

328328
## Release Notes
329+
### 1.2.12
330+
- Update as per github issue #28, python code update to splunkversioncontrol_utility.py for Splunk 9.3 compatability contributed by ParksBra
331+
329332
### 1.2.11
330333
Library updates:
331334
- Updated Splunk python SDK to 2.0.1

bin/splunkversioncontrol_utility.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ def runOSProcess(command, logger, timeout=60, shell=True):
3535
finally:
3636
timer.cancel()
3737

38-
if not timer.isAlive():
38+
# As per https://github.com/gjanders/SplunkVersionControl/issues/28
39+
if not getattr(timer, "isAlive", getattr(timer, "is_alive"))(): # Compatibility with >py3.8
3940
res = False
4041
logger.warn("OS process timed out after %s seconds, for command %s" % (timeout, command))
4142
proc.terminate()

default/app.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ label = SplunkVersionControl
1212
[launcher]
1313
author = Gareth Anderson
1414
description = Version Control software for Splunk instances (backup/restore from git)
15-
version = 1.2.11
15+
version = 1.2.12
1616

1717
[package]
1818
id = SplunkVersionControl

0 commit comments

Comments
 (0)