Don't test dependency management since its testing require and is brittle

Author: Simeon F. Willbanks

test/html/pipeline/autolink_filter_test.rb

@@ -3,10 +3,6 @@
 AutolinkFilter = HTML::Pipeline::AutolinkFilter
 
 class HTML::Pipeline::AutolinkFilterTest < Test::Unit::TestCase
-  def test_dependency_management
-    assert_dependency "autolink_filter", "rinku"
-  end
-
   def test_uses_rinku_for_autolinking
     # just try to parse a complicated piece of HTML
     # that Rails auto_link cannot handle

test/html/pipeline/email_reply_filter_test.rb

@@ -1,16 +1,12 @@
-require "test_helper"
+require 'test_helper'
 
 class HTML::Pipeline::EmojiFilterTest < Test::Unit::TestCase
   EmojiFilter = HTML::Pipeline::EmojiFilter
-
-  def test_dependency_management
-    assert_dependency "emoji_filter", "gemoji"
-  end
-
+  
   def test_emojify
-    filter = EmojiFilter.new("<p>:shipit:</p>", {:asset_root => "https://foo.com"})
+    filter = EmojiFilter.new("<p>:shipit:</p>", {:asset_root => 'https://foo.com'})
     doc = filter.call
-    assert_match "https://foo.com/emoji/shipit.png", doc.search("img").attr("src").value
+    assert_match "https://foo.com/emoji/shipit.png", doc.search('img').attr('src').value
   end
 
   def test_required_context_validation
@@ -19,4 +15,4 @@ def test_required_context_validation
     }
     assert_match /:asset_root/, exception.message
   end
-end
+end

test/html/pipeline/emoji_filter_test.rb

@@ -18,10 +18,6 @@ def setup
       "```"
   end
 
-  def test_dependency_management
-    assert_dependency "markdown_filter", "github-markdown"
-  end
-
   def test_fails_when_given_a_documentfragment
     body = "<p>heyo</p>"
     doc  = HTML::Pipeline.parse(body)
@@ -31,26 +27,26 @@ def test_fails_when_given_a_documentfragment
   def test_gfm_enabled_by_default
     doc = MarkdownFilter.to_document(@haiku, {})
     assert doc.kind_of?(HTML::Pipeline::DocumentFragment)
-    assert_equal 2, doc.search("br").size
+    assert_equal 2, doc.search('br').size
   end
 
   def test_disabling_gfm
     doc = MarkdownFilter.to_document(@haiku, :gfm => false)
     assert doc.kind_of?(HTML::Pipeline::DocumentFragment)
-    assert_equal 0, doc.search("br").size
+    assert_equal 0, doc.search('br').size
   end
 
   def test_fenced_code_blocks
     doc = MarkdownFilter.to_document(@code)
     assert doc.kind_of?(HTML::Pipeline::DocumentFragment)
-    assert_equal 1, doc.search("pre").size
+    assert_equal 1, doc.search('pre').size
   end
 
   def test_fenced_code_blocks_with_language
     doc = MarkdownFilter.to_document(@code.sub("```", "``` ruby"))
     assert doc.kind_of?(HTML::Pipeline::DocumentFragment)
-    assert_equal 1, doc.search("pre").size
-    assert_equal "ruby", doc.search("pre").first["lang"]
+    assert_equal 1, doc.search('pre').size
+    assert_equal 'ruby', doc.search('pre').first['lang']
   end
 end
 

test/html/pipeline/markdown_filter_test.rb

@@ -3,10 +3,6 @@
 class HTML::Pipeline::PlainTextInputFilterTest < Test::Unit::TestCase
   PlainTextInputFilter = HTML::Pipeline::PlainTextInputFilter
 
-  def test_dependency_management
-    assert_dependency "plain_text_input_filter", "escape_utils"
-  end
-
   def test_fails_when_given_a_documentfragment
     body = "<p>heyo</p>"
     doc  = Nokogiri::HTML::DocumentFragment.parse(body)

test/html/pipeline/plain_text_input_filter_test.rb

@@ -3,10 +3,6 @@
 class HTML::Pipeline::SanitizationFilterTest < Test::Unit::TestCase
   SanitizationFilter = HTML::Pipeline::SanitizationFilter
 
-  def test_dependency_management
-    assert_dependency "sanitization_filter", "sanitize"
-  end
-
   def test_removing_script_tags
     orig = %(<p><img src="http://github.com/img.png" /><script></script></p>)
     html = SanitizationFilter.call(orig).to_s

test/html/pipeline/sanitization_filter_test.rb

@@ -3,10 +3,6 @@
 SyntaxHighlightFilter = HTML::Pipeline::SyntaxHighlightFilter
 
 class HTML::Pipeline::SyntaxHighlightFilterTest < Test::Unit::TestCase
-  def test_dependency_management
-    assert_dependency "syntax_highlight_filter", "github-linguist"
-  end
-
   def test_highlight_default
     filter = SyntaxHighlightFilter.new \
       "<pre>hello</pre>", :highlight => "coffeescript"

test/html/pipeline/syntax_highlight_filter_test.rb

@@ -1,15 +1,15 @@
-require "bundler/setup"
-require "html/pipeline"
-require "test/unit"
+require 'bundler/setup'
+require 'html/pipeline'
+require 'test/unit'
 
-require "active_support/core_ext/string"
-require "active_support/core_ext/object/try"
+require 'active_support/core_ext/string'
+require 'active_support/core_ext/object/try'
 
 module TestHelpers
   # Asserts that `needle` is not a member of `haystack`, where
   # `haystack` is any object that responds to `include?`.
   def assert_doesnt_include(needle, haystack, message = nil)
-    error = "<?> included in <?>"
+    error = '<?> included in <?>'
     message = build_message(message, error, needle.to_s, Array(haystack).map(&:to_s))
 
     assert_block message do
@@ -20,7 +20,7 @@ def assert_doesnt_include(needle, haystack, message = nil)
   # Asserts that `needle` is a member of `haystack`, where
   # `haystack` is any object that responds to `include?`.
   def assert_includes(needle, haystack, message = nil)
-    error = "<?> not included in <?>"
+    error = '<?> not included in <?>'
     message = build_message(message, error, needle.to_s, Array(haystack).map(&:to_s))
 
     assert_block message do
@@ -34,24 +34,6 @@ def assert_equal_html(expected, actual)
     assert_equal Nokogiri::HTML::DocumentFragment.parse(expected).to_hash,
                  Nokogiri::HTML::DocumentFragment.parse(actual).to_hash
   end
-
-  # Asserts that when a Filter is loaded without its dependencies installed,
-  # a HTML::Pipeline::Filter::MissingDependencyException is raised with a
-  # message describing the problem and a fix.
-  def assert_dependency(filter_name, gem_name)
-    Kernel.module_eval do
-      def require(name)
-        raise LoadError
-      end
-    end
-
-    exception = assert_raise HTML::Pipeline::Filter::MissingDependencyException do
-      load File.join(File.dirname(__FILE__), "..", "lib", "html", "pipeline", "#{filter_name}.rb")
-    end
-
-    assert_equal exception.message,
-      "Missing html-pipeline dependency: Please add `#{gem_name}` to your Gemfile; see html-pipeline Gemfile for version."
-  end
 end
 
 Test::Unit::TestCase.send(:include, TestHelpers)