Merge pull request #414 from gjtorikian/fix-sanitization-only

Bugfix: sanitization-only filters should still work

Author: gjtorikian

lib/html_pipeline.rb

@@ -183,8 +183,8 @@ def call(text, context: {}, result: {})
 
     if @node_filters.empty?
       instrument("sanitization.html_pipeline", payload) do
-        result[:output] = Selma::Rewriter.new(sanitizer: @sanitization_config, handlers: @node_filters, options: rewriter_options).rewrite(html)
-      end unless @convert_filter.nil? # no html, so no sanitization
+        result[:output] = Selma::Rewriter.new(sanitizer: @sanitization_config, options: rewriter_options).rewrite(html)
+      end
     else
       instrument("call_node_filters.html_pipeline", payload) do
         @node_filters.each { |filter| filter.context = (filter.context || {}).merge(context) }

lib/html_pipeline/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class HTMLPipeline
-  VERSION = "3.2.1"
+  VERSION = "3.2.2"
 end

test/sanitization_filter_test.rb

@@ -289,5 +289,23 @@ def test_sanitization_pipeline_does_not_need_node_filters
 
       assert_equal(result[:output].to_s, expected.chomp)
     end
+
+    def test_a_sanitization_only_pipeline_works
+      config = Selma::Sanitizer::Config.freeze_config({
+        elements: [
+          "strong",
+        ],
+      })
+
+      pipeline = HTMLPipeline.new(
+        sanitization_config: config,
+      )
+
+      text = "<p>Some <strong>plain</strong> text</p>"
+      result = pipeline.call(text)
+      expected = "Some <strong>plain</strong> text"
+
+      assert_equal(result[:output].to_s, expected)
+    end
   end
 end