Removing the ability to disable

Just don't include it in the pipeline if you don't want it

Author: gjtorikian

lib/html_pipeline/node_filter/asset_proxy_filter.rb

@@ -20,8 +20,6 @@ def selector
       end
 
       def handle_element(element)
-        return unless asset_proxy_enabled?
-
         original_src = element["src"]
         return unless original_src
 
@@ -51,9 +49,6 @@ class << self
         # all the necessary keys in the context. One example would be to override
         # this and pull the settings from a set of global application settings.
         def transform_context(context, proxy_settings = {})
-          context[:asset_proxy_enabled] = proxy_settings.fetch(:enabled, true)
-          return context unless context[:asset_proxy_enabled]
-
           context[:asset_proxy] = proxy_settings[:url] if proxy_settings[:url]
           context[:asset_proxy_secret_key] = proxy_settings[:secret_key] if proxy_settings[:secret_key]
 
@@ -75,13 +70,7 @@ def determine_allowlist(proxy_settings)
         end
       end
 
-      private
-
-      def asset_proxy_enabled?
-        context[:asset_proxy_enabled]
-      end
-
-      def asset_proxy_url(url)
+      private def asset_proxy_url(url)
         "#{context[:asset_proxy]}/#{asset_url_hash(url)}/#{hexencode(url)}"
       end
 

test/html_pipeline/node_filter/asset_proxy_filter_test.rb

@@ -14,21 +14,6 @@ def image(path)
       %(<img src="#{path}" />)
     end
 
-    it "does not replace if disabled" do
-      settings = {
-        enabled: false,
-        secret_key: "shared-secret",
-        url: "https://assets.example.com",
-        allowlist: ["somewhere.com", "*.mydomain.com"],
-      }
-
-      context = DESCRIBED_CLASS.transform_context({}, settings)
-      src = "http://example.com/test.png"
-      res = @filter.call(image(src), context: context)
-
-      assert_equal(image(src), res)
-    end
-
     describe "setting up the context" do
       it "#transform_context" do
         settings = {
@@ -40,7 +25,6 @@ def image(path)
 
         context = DESCRIBED_CLASS.transform_context({}, settings)
 
-        assert(context[:asset_proxy_enabled])
         assert_equal("shared-secret", context[:asset_proxy_secret_key])
         assert_equal("https://assets.example.com", context[:asset_proxy])
         assert_equal(/^(somewhere\.com|.*?\.mydomain\.com)$/i, context[:asset_proxy_domain_regexp])