Address Pull Request comments:

Simeon F. Willbanks · Simeon F. Willbanks · commit c25c89098045 · 2013-08-27T19:19:13.000-07:00
* Copy edit README.md
* In gemspec, link README.md dependencies and update post install message
* Rename test helper to `assert_dependency`
* Remove `TestingDependency` in favor of stubbing `Kernal#require`
diff --git a/README.md b/README.md
@@ -103,7 +103,7 @@ filter.call
 Filter gem dependencies are not bundled; you must bundle the filter's gem
 dependencies. The below list details filters with dependencies. For example,
 `SyntaxHighlightFilter` uses [github-linguist](https://github.com/github/linguist)
-to detect and highlight languages. To use the `SyntaxHighlightFilter`,
+to detect and highlight languages. For example, to use the `SyntaxHighlightFilter`,
 add the following to your Gemfile:
 
 ```ruby
diff --git a/html-pipeline.gemspec b/html-pipeline.gemspec
@@ -20,12 +20,11 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "activesupport", RUBY_VERSION < "1.9.3" ? [">= 2", "< 4"] : ">= 2"
 
   gem.post_install_message = <<msg
-----------------------------------------------
+-------------------------------------------------
 Thank you for installing html-pipeline!
-Filter gem dependencies are no longer bundled.
 You must bundle Filter gem dependencies.
 See html-pipeline README.md for more details.
-https://github.com/jch/html-pipeline
-----------------------------------------------
+https://github.com/jch/html-pipeline#dependencies
+-------------------------------------------------
 msg
 end
diff --git a/test/helpers/testing_dependency.rb b/test/helpers/testing_dependency.rb
diff --git a/test/html/pipeline/autolink_filter_test.rb b/test/html/pipeline/autolink_filter_test.rb
@@ -4,7 +4,7 @@
 
 class HTML::Pipeline::AutolinkFilterTest < Test::Unit::TestCase
   def test_dependency_management
-    assert_dependency_management_error "autolink_filter", "rinku"
+    assert_dependency "autolink_filter", "rinku"
   end
 
   def test_uses_rinku_for_autolinking
diff --git a/test/html/pipeline/email_reply_filter_test.rb b/test/html/pipeline/email_reply_filter_test.rb
@@ -2,6 +2,6 @@
 
 class HTML::Pipeline::EmailReplyFilterTest < Test::Unit::TestCase
   def test_dependency_management
-    assert_dependency_management_error "email_reply_filter", "escape_utils"
+    assert_dependency "email_reply_filter", "escape_utils"
   end
 end
diff --git a/test/html/pipeline/emoji_filter_test.rb b/test/html/pipeline/emoji_filter_test.rb
@@ -4,7 +4,7 @@ class HTML::Pipeline::EmojiFilterTest < Test::Unit::TestCase
   EmojiFilter = HTML::Pipeline::EmojiFilter
 
   def test_dependency_management
-    assert_dependency_management_error "emoji_filter", "gemoji"
+    assert_dependency "emoji_filter", "gemoji"
   end
 
   def test_emojify
diff --git a/test/html/pipeline/markdown_filter_test.rb b/test/html/pipeline/markdown_filter_test.rb
@@ -19,7 +19,7 @@ def setup
   end
 
   def test_dependency_management
-    assert_dependency_management_error "markdown_filter", "github-markdown"
+    assert_dependency "markdown_filter", "github-markdown"
   end
 
   def test_fails_when_given_a_documentfragment
diff --git a/test/html/pipeline/plain_text_input_filter_test.rb b/test/html/pipeline/plain_text_input_filter_test.rb
@@ -4,7 +4,7 @@ class HTML::Pipeline::PlainTextInputFilterTest < Test::Unit::TestCase
   PlainTextInputFilter = HTML::Pipeline::PlainTextInputFilter
 
   def test_dependency_management
-    assert_dependency_management_error "plain_text_input_filter", "escape_utils"
+    assert_dependency "plain_text_input_filter", "escape_utils"
   end
 
   def test_fails_when_given_a_documentfragment
diff --git a/test/html/pipeline/sanitization_filter_test.rb b/test/html/pipeline/sanitization_filter_test.rb
@@ -4,7 +4,7 @@ class HTML::Pipeline::SanitizationFilterTest < Test::Unit::TestCase
   SanitizationFilter = HTML::Pipeline::SanitizationFilter
 
   def test_dependency_management
-    assert_dependency_management_error "sanitization_filter", "sanitize"
+    assert_dependency "sanitization_filter", "sanitize"
   end
 
   def test_removing_script_tags
diff --git a/test/html/pipeline/syntax_highlight_filter_test.rb b/test/html/pipeline/syntax_highlight_filter_test.rb
@@ -2,6 +2,6 @@
 
 class HTML::Pipeline::SyntaxHighlightFilterTest < Test::Unit::TestCase
   def test_dependency_management
-    assert_dependency_management_error "syntax_highlight_filter", "github-linguist"
+    assert_dependency "syntax_highlight_filter", "github-linguist"
   end
 end
diff --git a/test/html/pipeline/textile_filter_test.rb b/test/html/pipeline/textile_filter_test.rb
@@ -2,6 +2,6 @@
 
 class HTML::Pipeline::TextileFilterTest < Test::Unit::TestCase
   def test_dependency_management
-    assert_dependency_management_error "textile_filter", "RedCloth"
+    assert_dependency "textile_filter", "RedCloth"
   end
 end
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -1,7 +1,6 @@
 require "bundler/setup"
 require "html/pipeline"
 require "test/unit"
-require "helpers/testing_dependency"
 
 require "active_support/core_ext/object/try"
 
@@ -38,15 +37,19 @@ def assert_equal_html(expected, actual)
   # Asserts that when a Filter is loaded without its dependencies installed,
   # a HTML::Pipeline::Filter::MissingDependencyException is raised with a
   # message describing the problem and a fix.
-  def assert_dependency_management_error(filter_name, gem_name)
-    TestingDependency.temporarily_remove_dependency_by gem_name do
-      exception = assert_raise HTML::Pipeline::Filter::MissingDependencyException do
-        load TestingDependency.filter_path_from filter_name
+  def assert_dependency(filter_name, gem_name)
+    Kernel.module_eval do
+      def require(name)
+        raise LoadError
       end
+    end
 
-      assert_equal exception.message,
-        "Missing html-pipeline dependency: Please add `#{gem_name}` to your Gemfile; see html-pipeline Gemfile for version."
+    exception = assert_raise HTML::Pipeline::Filter::MissingDependencyException do
+      load File.join(File.dirname(__FILE__), "..", "lib", "html", "pipeline", "#{filter_name}.rb")
     end
+
+    assert_equal exception.message,
+      "Missing html-pipeline dependency: Please add `#{gem_name}` to your Gemfile; see html-pipeline Gemfile for version."
   end
 end
 
