initialize new color array to 1.0

gkjohnson · gkjohnson · commit 0f2066849e63 · 2022-10-12T14:34:23.000-07:00
diff --git a/src/utils/GeometryPreparationUtils.js b/src/utils/GeometryPreparationUtils.js
@@ -115,7 +115,9 @@ export function setCommonAttributes( geometry, options ) {
 	if ( ! geometry.attributes.color && ( attributes && attributes.includes( 'color' ) ) ) {
 
 		const vertCount = geometry.attributes.position.count;
-		geometry.setAttribute( 'color', new BufferAttribute( new Float32Array( vertCount * 4 ), 4 ) );
+		const array = new Float32Array( vertCount * 4 );
+		array.fill( 1.0 );
+		geometry.setAttribute( 'color', new BufferAttribute( array, 4 ) );
 
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,9 @@ export function setCommonAttributes( geometry, options ) {`
`115`	`115`	`if ( ! geometry.attributes.color && ( attributes && attributes.includes( 'color' ) ) ) {`
`116`	`116`
`117`	`117`	`const vertCount = geometry.attributes.position.count;`
`118`		`- geometry.setAttribute( 'color', new BufferAttribute( new Float32Array( vertCount * 4 ), 4 ) );`
	`118`	`+ const array = new Float32Array( vertCount * 4 );`
	`119`	`+ array.fill( 1.0 );`
	`120`	`+ geometry.setAttribute( 'color', new BufferAttribute( array, 4 ) );`
`119`	`121`
`120`	`122`	`}`
`121`	`123`