Raise inefficient 'list.length' usage warning in more cases

ankddev · lpil · commit 08fa3ae7933f · 2025-08-19T19:42:30.000+01:00
Signed-off-by: Andrey &lt;andrekabatareika@gmail.com&gt;
diff --git a/compiler-core/src/type_/expression.rs b/compiler-core/src/type_/expression.rs
@@ -4774,10 +4774,11 @@ fn get_empty_list_check_kind<'a>(
         }
         (_, TypedExpr::Int { value, .. }) => match (binop, value.as_str()) {
             (BinOp::LtEqInt, "0" | "-0") | (BinOp::LtInt, "1") => Some(EmptyListCheckKind::Empty),
+            (BinOp::GtInt, "0" | "-0") => Some(EmptyListCheckKind::NonEmpty),
             _ => None,
         },
         (TypedExpr::Int { value, .. }, _) => match (binop, value.as_str()) {
-            (BinOp::GtEqInt, "0" | "-0") | (BinOp::GtInt, "1") => {
+            (BinOp::GtEqInt, "0" | "-0") | (BinOp::GtInt, "1") | (BinOp::LtInt, "0" | "-0") => {
                 Some(EmptyListCheckKind::NonEmpty)
             }
             _ => None,

Original file line number	Diff line number	Diff line change
`@@ -4774,10 +4774,11 @@ fn get_empty_list_check_kind<'a>(`
`4774`	`4774`	`}`
`4775`	`4775`	`(_, TypedExpr::Int { value, .. }) => match (binop, value.as_str()) {`
`4776`	`4776`	`(BinOp::LtEqInt, "0" \| "-0") \| (BinOp::LtInt, "1") => Some(EmptyListCheckKind::Empty),`
	`4777`	`+ (BinOp::GtInt, "0" \| "-0") => Some(EmptyListCheckKind::NonEmpty),`
`4777`	`4778`	`_ => None,`
`4778`	`4779`	`},`
`4779`	`4780`	`(TypedExpr::Int { value, .. }, _) => match (binop, value.as_str()) {`
`4780`		`- (BinOp::GtEqInt, "0" \| "-0") \| (BinOp::GtInt, "1") => {`
	`4781`	`+ (BinOp::GtEqInt, "0" \| "-0") \| (BinOp::GtInt, "1") \| (BinOp::LtInt, "0" \| "-0") => {`
`4781`	`4782`	`Some(EmptyListCheckKind::NonEmpty)`
`4782`	`4783`	`}`
`4783`	`4784`	`_ => None,`