stop crashing when there's an invalid version in a gleam.toml file

fixes #4817

Author: giacomocavalieri

CHANGELOG.md

@@ -138,3 +138,7 @@
   expression as safe to remove, instead of just highlighting the double
   negation.
   ([Giacomo Cavalieri](https://github.com/giacomocavalieri))
+
+- Fixed a bug where the compiler would crash if there was an invalid version
+  requirement in a project's `gleam.toml`.
+  ([Giacomo Cavalieri](https://github.com/giacomocavalieri))

compiler-core/src/requirement.rs

@@ -122,7 +122,10 @@ impl<'de> Visitor<'de> for RequirementVisitor {
     where
         E: de::Error,
     {
-        Ok(FromStr::from_str(value).expect("expected string"))
+        match value.parse::<Requirement>() {
+            Ok(value) => Ok(value),
+            Err(error) => Err(de::Error::custom(error)),
+        }
     }
 
     fn visit_map<M>(self, visitor: M) -> Result<Self::Value, M::Error>
@@ -165,4 +168,15 @@ mod tests {
             Requirement::git("https://github.com/gleam-lang/otp.git", "4d34935")
         );
     }
+
+    #[test]
+    fn read_wrong_version() {
+        let toml = r#"
+            short = ">= 2.0 and < 3.0.0"
+        "#;
+
+        let error =
+            toml::from_str::<HashMap<String, Requirement>>(toml).expect_err("invalid version");
+        insta::assert_snapshot!(error.to_string());
+    }
 }

compiler-core/src/snapshots/gleam_core__requirement__tests__read_wrong_version.snap

@@ -0,0 +1,5 @@
+---
+source: compiler-core/src/requirement.rs
+expression: error.to_string()
+---
+>= 2.0 and < 3.0.0 is not a valid version. missing patch version: 2.0 for key `short` at line 2 column 21