refactor(dependencies): remove default impl for DependencyManagerConfig ♻️

Author: andho

compiler-cli/src/add.rs

@@ -1,6 +1,7 @@
 use camino::{Utf8Path, Utf8PathBuf};
 
 use gleam_core::{
+    build::Mode,
     Error, Result,
     error::{FileIoAction, FileKind},
     paths::ProjectPaths,
@@ -33,8 +34,9 @@ pub fn command(paths: &ProjectPaths, packages_to_add: Vec<String>, dev: bool) ->
         Some((new_package_requirements.clone(), dev)),
         Vec::new(),
         dependencies::DependencyManagerConfig {
+            mode: Mode::Dev,
             use_manifest: dependencies::UseManifest::Yes,
-            ..Default::default()
+            check_major_versions: dependencies::CheckMajorVersions::No,
         },
     )?;
 

compiler-cli/src/build.rs

@@ -2,7 +2,7 @@ use std::{rc::Rc, time::Instant};
 
 use gleam_core::{
     Result,
-    build::{Built, Codegen, NullTelemetry, Options, ProjectCompiler, Telemetry},
+    build::{Built, Codegen, Mode, NullTelemetry, Options, ProjectCompiler, Telemetry},
     manifest::Manifest,
     paths::ProjectPaths,
     warning::WarningEmitterIO,
@@ -21,8 +21,9 @@ pub fn download_dependencies(paths: &ProjectPaths, telemetry: impl Telemetry) ->
         None,
         Vec::new(),
         dependencies::DependencyManagerConfig {
+            mode: Mode::Dev,
             use_manifest: dependencies::UseManifest::Yes,
-            ..Default::default()
+            check_major_versions: dependencies::CheckMajorVersions::No,
         },
     )
 }

compiler-cli/src/dependencies.rs

@@ -92,8 +92,9 @@ fn get_manifest_details(paths: &ProjectPaths) -> Result<(PackageConfig, Manifest
     let config = crate::config::root_config(paths)?;
     let package_fetcher = PackageFetcher::new(runtime.handle().clone());
     let dependency_manager = DependencyManagerConfig {
+        mode: Mode::Dev,
         use_manifest: UseManifest::Yes,
-        ..Default::default()
+        check_major_versions: CheckMajorVersions::No,
     }
     .into_dependency_manager(
         runtime.handle().clone(),
@@ -228,9 +229,9 @@ pub fn update(paths: &ProjectPaths, packages: Vec<String>) -> Result<()> {
         None,
         packages.into_iter().map(EcoString::from).collect(),
         DependencyManagerConfig {
+            mode: Mode::Dev,
             use_manifest,
             check_major_versions: CheckMajorVersions::Yes,
-            ..Default::default()
         },
     )?;
 
@@ -650,16 +651,6 @@ pub struct DependencyManagerConfig {
     pub check_major_versions: CheckMajorVersions,
 }
 
-impl Default for DependencyManagerConfig {
-    fn default() -> Self {
-        Self {
-            mode: Mode::Dev,
-            use_manifest: UseManifest::No,
-            check_major_versions: CheckMajorVersions::No,
-        }
-    }
-}
-
 impl DependencyManagerConfig {
     pub fn into_dependency_manager<Telem: Telemetry, P: dependency::PackageFetcher>(
         self,

compiler-cli/src/fs.rs

@@ -1,6 +1,6 @@
 use gleam_core::{
     Result, Warning,
-    build::{NullTelemetry, Target},
+    build::{Mode, NullTelemetry, Target},
     error::{Error, FileIoAction, FileKind, OS, ShellCommandFailureReason, parse_os},
     io::{
         BeamCompiler, Command, CommandExecutor, Content, DirEntry, FileSystemReader,
@@ -252,8 +252,9 @@ impl DownloadDependencies for ProjectIO {
             None,
             Vec::new(),
             dependencies::DependencyManagerConfig {
+                mode: Mode::Dev,
                 use_manifest: dependencies::UseManifest::Yes,
-                ..Default::default()
+                check_major_versions: dependencies::CheckMajorVersions::No,
             },
         )
     }

compiler-cli/src/lib.rs

@@ -781,9 +781,9 @@ fn download_dependencies(paths: &ProjectPaths) -> Result<()> {
         None,
         Vec::new(),
         dependencies::DependencyManagerConfig {
+            mode: Mode::Dev,
             use_manifest: dependencies::UseManifest::Yes,
-            check_major_versions: dependencies::CheckMajorVersions::Yes,
-            ..Default::default()
+            check_major_versions: dependencies::CheckMajorVersions::No,
         },
     )?;
     Ok(())