gleam update should return error if package does not exists

Author: vshakitskiy

CHANGELOG.md

@@ -428,3 +428,7 @@
 - The compiler now provides a clearer error message when a function's return type
   is mistakenly declared using `:` instead of `->`.
   ([Gurvir Singh](https://github.com/baraich))
+
+- Added an error message when attempting to update packages that are not dependencies
+  of the project, instead of failing silently.
+  ([Etienne Boutet](https://github.com/EtienneBoutet)) and ([Vladislav Shakitskiy](https://github.com/vshakitskiy))

compiler-cli/src/dependencies/dependency_manager.rs

@@ -81,10 +81,12 @@ where
         if !paths.manifest().exists() {
             tracing::debug!("manifest_not_present");
             let manifest = self.perform_version_resolution(paths, config, None, Vec::new())?;
+            self.ensure_packages_exist_locally(&manifest, packages_to_update.clone())?;
             return Ok(Resolved::all_added(manifest));
         }
 
         let existing_manifest = read_manifest_from_disc(paths)?;
+        self.ensure_packages_exist_locally(&existing_manifest, packages_to_update.clone())?;
 
         // If we have been asked not to use the manifest then
         let (requirements_changed, manifest_for_resolver) = match self.use_manifest {
@@ -123,6 +125,25 @@ where
         Ok(resolved)
     }
 
+    fn ensure_packages_exist_locally(
+        &self,
+        manifest: &Manifest,
+        packages: Vec<EcoString>,
+    ) -> Result<()> {
+        let missing_packages: Vec<String> = packages
+            .iter()
+            .filter(|package_name| !manifest.packages.iter().any(|p| &p.name == *package_name))
+            .map(|eco| eco.to_string())
+            .collect();
+
+        if !missing_packages.is_empty() {
+            return Err(Error::PackagesToUpdateNotExist {
+                packages: missing_packages,
+            });
+        }
+        Ok(())
+    }
+
     pub fn resolve_and_download_versions(
         &self,
         paths: &ProjectPaths,

compiler-core/src/error.rs

@@ -205,6 +205,9 @@ file_names.iter().map(|x| x.as_str()).join(", "))]
     #[error("Packages not exist: {}", packages.iter().join(", "))]
     RemovedPackagesNotExist { packages: Vec<String> },
 
+    #[error("Packages to update not exist: {}", packages.iter().join(", "))]
+    PackagesToUpdateNotExist { packages: Vec<String> },
+
     #[error("unable to find project root")]
     UnableToFindProjectRoot { path: String },
 
@@ -1001,6 +1004,24 @@ If you want to overwrite these files, delete them and run the command again.
                     "These packages are not dependencies of your package so they could not
 be removed.
 
+{}
+",
+                    packages
+                        .iter()
+                        .map(|p| format!("  - {}", p.as_str()))
+                        .join("\n")
+                ),
+                level: Level::Error,
+                hint: None,
+                location: None,
+            }],
+
+            Error::PackagesToUpdateNotExist { packages } => vec![Diagnostic {
+                title: "Packages to update not found".into(),
+                text: format!(
+                    "These packages are not dependencies of your package so they could not
+be updated.
+
 {}
 ",
                     packages