Error for invalid dependency specification

Closes #4867

Author: lpil

CHANGELOG.md

@@ -261,6 +261,11 @@
   dependencies to be imported.
   ([Surya Rose](https://github.com/GearsDatapacks))
 
+- Erroneous extra fields in `gleam.toml` dependency specifications will no
+  longer be siltently ignored. An error is now returned highlighting the
+  problem instead.
+  ([Louis Pilfold](https://github.com/lpil))
+
 - Fixed a bug where renaming a constant which is referenced in another module
   inside a guard would generate invalid code.
   ([Surya Rose](https://github.com/GearsDatapacks))

compiler-core/src/config.rs

@@ -218,13 +218,7 @@ impl PackageConfig {
         fs: &FS,
     ) -> Result<PackageConfig, Error> {
         let toml = fs.read(path.as_ref())?;
-        let config: PackageConfig = toml::from_str(&toml).map_err(|e| Error::FileIo {
-            action: FileIoAction::Parse,
-            kind: FileKind::File,
-            path: path.as_ref().to_path_buf(),
-            err: Some(e.to_string()),
-        })?;
-        Ok(config)
+        deserialise_config(path, toml)
     }
 
     /// Get the locked packages for the current config and a given (optional)
@@ -322,6 +316,37 @@ impl PackageConfig {
     }
 }
 
+fn deserialise_config<P: AsRef<Utf8Path>>(
+    path: P,
+    toml: String,
+) -> std::result::Result<PackageConfig, Error> {
+    let config: PackageConfig = toml::from_str(&toml).map_err(|e| Error::FileIo {
+        action: FileIoAction::Parse,
+        kind: FileKind::File,
+        path: path.as_ref().to_path_buf(),
+        err: Some(e.to_string()),
+    })?;
+    Ok(config)
+}
+
+// https://github.com/gleam-lang/gleam/issues/4867
+#[test]
+fn deny_extra_deps_properties() {
+    let toml = r#"
+name = "wibble"
+version = "1.0.0"
+
+[dependencies]
+aide_generator = { git = "[email protected]:crowdhailer/aide.git", ref = "f559c5bc", extra = "idk what this is" }
+"#;
+    let error = deserialise_config("gleam.toml", toml.into())
+        .expect_err("should fail to deserialise because of additional path");
+    assert_eq!(
+        error.to_string(),
+        r#"Parse "gleam.toml" failed: Some("data did not match any variant of untagged enum Requirement for key `dependencies.aide_generator` at line 6 column 18")"#
+    );
+}
+
 #[test]
 fn locked_no_manifest() {
     let mut config = PackageConfig::default();

compiler-core/src/error.rs

@@ -115,7 +115,7 @@ pub enum Error {
     #[error("cyclical package dependencies")]
     PackageCycle { packages: Vec<EcoString> },
 
-    #[error("file operation failed")]
+    #[error("{action:?} {path:?} failed: {err:?}")]
     FileIo {
         kind: FileKind,
         action: FileIoAction,

compiler-core/src/requirement.rs

@@ -12,12 +12,13 @@ use serde::de::{self, Deserializer, MapAccess, Visitor};
 use serde::ser::{Serialize, SerializeMap, Serializer};
 
 #[derive(Deserialize, Debug, PartialEq, Eq, Clone)]
-#[serde(untagged, remote = "Self")]
+#[serde(untagged, remote = "Self", deny_unknown_fields)]
 pub enum Requirement {
     Hex {
         #[serde(deserialize_with = "deserialise_range")]
         version: Range,
     },
+
     Path {
         path: Utf8PathBuf,
     },