Remove extra line

Author: lpil

compiler-core/src/javascript.rs

@@ -362,7 +362,7 @@ impl<'a> Generator<'a> {
 
         let mut definitions = constructors
             .iter()
-            .map(|constructor| self.record_definition(constructor, name, constructor_publicity))
+            .map(|constructor| self.variant_definition(constructor, name, constructor_publicity))
             .collect_vec();
 
         // Generate getters for fields shared between variants
@@ -380,23 +380,23 @@ impl<'a> Generator<'a> {
         definitions
     }
 
-    fn record_definition(
+    fn variant_definition(
         &self,
         constructor: &'a TypedRecordConstructor,
         type_name: &'a str,
         publicity: Publicity,
     ) -> Document<'a> {
-        let class_definition = self.record_class_definition(constructor, publicity);
+        let class_definition = self.variant_class_definition(constructor, publicity);
 
         // If the custom type is private or opaque, we don't need to generate API
         // functions for it.
         if publicity.is_private() {
             return class_definition;
         }
 
-        let constructor_definition = self.record_constructor_definition(constructor, type_name);
-        let variant_check_definition = self.record_check_definition(constructor, type_name);
-        let fields_definition = self.record_fields_definition(constructor, type_name);
+        let constructor_definition = self.variant_constructor_definition(constructor, type_name);
+        let variant_check_definition = self.variant_check_definition(constructor, type_name);
+        let fields_definition = self.variant_fields_definition(constructor, type_name);
 
         docvec![
             class_definition,
@@ -408,7 +408,7 @@ impl<'a> Generator<'a> {
         ]
     }
 
-    fn record_constructor_definition(
+    fn variant_constructor_definition(
         &self,
         constructor: &'a TypedRecordConstructor,
         type_name: &'a str,
@@ -445,7 +445,7 @@ impl<'a> Generator<'a> {
         ]
     }
 
-    fn record_check_definition(
+    fn variant_check_definition(
         &self,
         constructor: &'a TypedRecordConstructor,
         type_name: &'a str,
@@ -468,7 +468,7 @@ impl<'a> Generator<'a> {
         ]
     }
 
-    fn record_fields_definition(
+    fn variant_fields_definition(
         &self,
         constructor: &'a TypedRecordConstructor,
         type_name: &'a str,
@@ -528,27 +528,23 @@ impl<'a> Generator<'a> {
         type_name: &'a str,
         shared_accessors: &HashMap<EcoString, RecordAccessor>,
     ) -> Document<'a> {
-        let mut functions = Vec::new();
-
-        for field in shared_accessors.keys().sorted() {
+        let accessors = shared_accessors.keys().sorted().map(|field| {
             let function_name = eco_format!("{type_name}${field}");
 
             let contents =
                 docvec![break_("", " "), "value.", maybe_escape_property(field), ";"].group();
 
-            functions.push(docvec![
-                line(),
+            docvec![
                 "export const ",
                 function_name,
                 " = (value) =>",
                 contents.nest(INDENT),
-            ]);
-        }
-
-        concat(functions)
+            ]
+        });
+        concat(Itertools::intersperse(accessors, line()))
     }
 
-    fn record_class_definition(
+    fn variant_class_definition(
         &self,
         constructor: &'a TypedRecordConstructor,
         publicity: Publicity,

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__custom_types__constructors_get_their_own_jsdoc.snap

@@ -1,6 +1,8 @@
 ---
 source: compiler-core/src/javascript/tests/custom_types.rs
+assertion_line: 678
 expression: "\npub type Wibble {\n  /// Wibbling!!\n  Wibble(field: Int)\n\n  /// Wobbling!!\n  Wobble(field: Int)\n}\n"
+snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -44,5 +46,4 @@ export const Wibble$isWobble = (value) => value instanceof Wobble;
 export const Wibble$Wobble$field = (value) => value.field;
 export const Wibble$Wobble$0 = (value) => value.field;
 
-
 export const Wibble$field = (value) => value.field;

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__records__record_accessor_multiple_variants.snap

@@ -1,6 +1,8 @@
 ---
 source: compiler-core/src/javascript/tests/records.rs
+assertion_line: 18
 expression: "\npub type Person {\n    Teacher(name: String, title: String)\n    Student(name: String, age: Int)\n}\npub fn get_name(person: Person) { person.name }"
+snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -41,7 +43,6 @@ export const Person$Student$0 = (value) => value.name;
 export const Person$Student$age = (value) => value.age;
 export const Person$Student$1 = (value) => value.age;
 
-
 export const Person$name = (value) => value.name;
 
 export function get_name(person) {

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__records__record_accessor_multiple_variants_parameterised_types.snap

@@ -1,6 +1,8 @@
 ---
 source: compiler-core/src/javascript/tests/records.rs
+assertion_line: 61
 expression: "\npub type Person {\n    Teacher(name: String, age: List(Int), title: String)\n    Student(name: String, age: List(Int))\n}\npub fn get_name(person: Person) { person.name }\npub fn get_age(person: Person) { person.age }"
+snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -46,7 +48,6 @@ export const Person$Student$0 = (value) => value.name;
 export const Person$Student$age = (value) => value.age;
 export const Person$Student$1 = (value) => value.age;
 
-
 export const Person$age = (value) => value.age;
 export const Person$name = (value) => value.name;
 

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__records__record_accessor_multiple_variants_positions_other_than_first.snap

@@ -1,6 +1,8 @@
 ---
 source: compiler-core/src/javascript/tests/records.rs
+assertion_line: 32
 expression: "\npub type Person {\n    Teacher(name: String, age: Int, title: String)\n    Student(name: String, age: Int)\n}\npub fn get_name(person: Person) { person.name }\npub fn get_age(person: Person) { person.age }"
+snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -46,7 +48,6 @@ export const Person$Student$0 = (value) => value.name;
 export const Person$Student$age = (value) => value.age;
 export const Person$Student$1 = (value) => value.age;
 
-
 export const Person$age = (value) => value.age;
 export const Person$name = (value) => value.name;
 

compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__records__record_accessor_multiple_with_first_position_different_types.snap

@@ -1,6 +1,8 @@
 ---
 source: compiler-core/src/javascript/tests/records.rs
+assertion_line: 47
 expression: "\npub type Person {\n    Teacher(name: Nil, age: Int)\n    Student(name: String, age: Int)\n}\npub fn get_age(person: Person) { person.age }"
+snapshot_kind: text
 ---
 ----- SOURCE CODE
 
@@ -41,7 +43,6 @@ export const Person$Student$0 = (value) => value.name;
 export const Person$Student$age = (value) => value.age;
 export const Person$Student$1 = (value) => value.age;
 
-
 export const Person$age = (value) => value.age;
 
 export function get_age(person) {