Skip to content

Commit 75e67e8

Browse files
andholpil
authored andcommitted
refactor(dependency): remove unnecessary clone and use max instead of sort ♻️
1 parent 507318e commit 75e67e8

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

compiler-core/src/dependency.rs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,12 @@ fn resolve_major_versions(
8080
return None;
8181
};
8282

83-
let Some(latest) = &hexpackage
83+
let latest = hexpackage
8484
.releases
8585
.iter()
86-
.map(|release| release.version.clone())
86+
.map(|release| &release.version)
8787
.filter(|version| !version.is_pre())
88-
.sorted_by(|a, b| b.cmp(a))
89-
.next()
90-
else {
91-
return None;
92-
};
88+
.max()?;
9389

9490
if latest.major <= version.major {
9591
return None;
@@ -996,7 +992,6 @@ mod tests {
996992
]
997993
.into_iter()
998994
.collect(),
999-
//requirements: HashMap::new(),
1000995
packages: vec![
1001996
ManifestPackage {
1002997
name: "direct_pkg_with_major_version".into(),

0 commit comments

Comments
 (0)