Remove unnecessary function

Author: GearsDatapacks

compiler-core/src/error.rs

@@ -1,7 +1,7 @@
 #![allow(clippy::unwrap_used, clippy::expect_used)]
 use crate::build::{Origin, Outcome, Runtime, Target};
 use crate::diagnostic::{Diagnostic, ExtraLabel, Label, Location};
-use crate::strings::{to_snake_case, to_upper_camel_case, uppercase_first_letter};
+use crate::strings::{to_snake_case, to_upper_camel_case};
 use crate::type_::collapse_links;
 use crate::type_::error::{
     InvalidImportKind, MissingAnnotation, ModuleValueUsageContext, Named, UnknownField,
@@ -3512,29 +3512,29 @@ See: https://tour.gleam.run/advanced-features/use/");
 
                 TypeError::BadName { location, name, kind } => {
                     let kind_str = kind.as_str();
-                    let label = format!("This is not a valid {kind_str} name");
+                    let label = format!("This is not a valid {} name", kind_str.to_lowercase());
                     let text = match kind {
                         Named::Type |
                         Named::TypeAlias |
                         Named::CustomTypeVariant => wrap_format!("Hint: {} names start with an uppercase \
 letter and contain only lowercase letters, numbers, \
 and uppercase letters.
-Try: {}", uppercase_first_letter(kind_str), to_upper_camel_case(name)),
+Try: {}", kind_str, to_upper_camel_case(name)),
                         Named::Variable |
                         Named::TypeVariable |
                         Named::Argument |
                         Named::Label |
                         Named::Constant  |
                         Named::Function => wrap_format!("Hint: {} names start with a lowercase letter \
 and contain a-z, 0-9, or _.
-Try: {}", uppercase_first_letter(kind_str), to_snake_case(name)),
+Try: {}", kind_str, to_snake_case(name)),
                         Named::Discard => wrap_format!("Hint: {} names start with _ and contain \
 a-z, 0-9, or _.
-Try: _{}", uppercase_first_letter(kind_str), to_snake_case(name)),
+Try: _{}", kind_str, to_snake_case(name)),
                     };
 
                     Diagnostic {
-                        title: format!("Invalid {kind_str} name"),
+                        title: format!("Invalid {} name", kind_str.to_lowercase()),
                         text,
                         hint: None,
                         level: Level::Error,

compiler-core/src/strings.rs

@@ -110,15 +110,3 @@ pub fn to_upper_camel_case(string: &str) -> EcoString {
 
     pascal_case
 }
-
-pub fn uppercase_first_letter(string: &str) -> EcoString {
-    let mut uppercased = EcoString::with_capacity(string.len());
-    let mut chars = string.chars();
-    if let Some(first) = chars.next() {
-        uppercased.push(first.to_ascii_uppercase());
-    }
-    for char in chars {
-        uppercased.push(char);
-    }
-    uppercased
-}

compiler-core/src/type_/error.rs

@@ -690,16 +690,16 @@ pub enum Named {
 impl Named {
     pub fn as_str(self) -> &'static str {
         match self {
-            Named::Type => "type",
-            Named::TypeAlias => "type alias",
-            Named::TypeVariable => "type variable",
-            Named::CustomTypeVariant => "type variant",
-            Named::Variable => "variable",
-            Named::Argument => "argument",
-            Named::Label => "label",
-            Named::Constant => "constant",
-            Named::Function => "function",
-            Named::Discard => "discard",
+            Named::Type => "Type",
+            Named::TypeAlias => "Type alias",
+            Named::TypeVariable => "Type variable",
+            Named::CustomTypeVariant => "Type variant",
+            Named::Variable => "Variable",
+            Named::Argument => "Argument",
+            Named::Label => "Label",
+            Named::Constant => "Constant",
+            Named::Function => "Function",
+            Named::Discard => "Discard",
         }
     }
 }