Skip to content

Commit 83a3914

Browse files
giacomocavalierilpil
authored andcommitted
remove duplicate function
1 parent 4ee641e commit 83a3914

File tree

2 files changed

+12
-21
lines changed

2 files changed

+12
-21
lines changed

compiler-core/src/erlang.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ use crate::{
2323
use camino::Utf8Path;
2424
use ecow::{EcoString, eco_format};
2525
use itertools::Itertools;
26-
use pattern::pattern;
2726
use regex::{Captures, Regex};
2827
use std::collections::HashSet;
2928
use std::sync::OnceLock;
@@ -1197,7 +1196,6 @@ fn let_assert<'a>(
11971196
None => string("Pattern match failed, no pattern matched the value."),
11981197
};
11991198

1200-
let mut vars: Vec<&str> = vec![];
12011199
let subject = maybe_block_expr(value, env);
12021200

12031201
// The code we generated for a `let assert` assignment looks something like
@@ -1258,6 +1256,7 @@ fn let_assert<'a>(
12581256
};
12591257

12601258
let mut guards = vec![];
1259+
let mut vars = vec![];
12611260
let pattern_document = pattern::to_doc(pattern, &mut vars, env, &mut guards);
12621261
let clause_guard = optional_clause_guard(None, guards, env);
12631262

@@ -1338,7 +1337,10 @@ fn let_assert<'a>(
13381337
fn let_<'a>(value: &'a TypedExpr, pat: &'a TypedPattern, env: &mut Env<'a>) -> Document<'a> {
13391338
let body = maybe_block_expr(value, env).group();
13401339
let mut guards = vec![];
1341-
pattern(pat, env, &mut guards).append(" = ").append(body)
1340+
1341+
pattern::to_doc(pat, &mut vec![], env, &mut guards)
1342+
.append(" = ")
1343+
.append(body)
13421344
}
13431345

13441346
fn float<'a>(value: &str) -> Document<'a> {
@@ -1554,13 +1556,11 @@ fn clause<'a>(clause: &'a TypedClause, env: &mut Env<'a>) -> Document<'a> {
15541556

15551557
let patterns_doc = if patterns.len() == 1 {
15561558
let p = patterns.first().expect("Single pattern clause printing");
1557-
pattern(p, env, &mut additional_guards)
1559+
pattern::to_doc(p, &mut vec![], env, &mut additional_guards)
15581560
} else {
1559-
tuple(
1560-
patterns
1561-
.iter()
1562-
.map(|p| pattern(p, env, &mut additional_guards)),
1563-
)
1561+
tuple(patterns.iter().map(|pattern| {
1562+
pattern::to_doc(pattern, &mut vec![], env, &mut additional_guards)
1563+
}))
15641564
};
15651565

15661566
let guard = optional_clause_guard(guard.as_ref(), additional_guards, env);

compiler-core/src/erlang/pattern.rs

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ use crate::analyse::Inferred;
66

77
use super::*;
88

9-
pub(super) fn pattern<'a>(
9+
pub(super) fn to_doc<'a>(
1010
p: &'a TypedPattern,
11+
vars: &mut Vec<&'a str>,
1112
env: &mut Env<'a>,
1213
guards: &mut Vec<Document<'a>>,
1314
) -> Document<'a> {
14-
let mut vars = vec![];
15-
to_doc(p, &mut vars, env, guards)
15+
print(p, vars, env, guards)
1616
}
1717

1818
fn print<'a>(
@@ -218,15 +218,6 @@ fn bit_array_size_operator<'a>(
218218
binop_documents(left, operator, right)
219219
}
220220

221-
pub(super) fn to_doc<'a>(
222-
p: &'a TypedPattern,
223-
vars: &mut Vec<&'a str>,
224-
env: &mut Env<'a>,
225-
guards: &mut Vec<Document<'a>>,
226-
) -> Document<'a> {
227-
print(p, vars, env, guards)
228-
}
229-
230221
fn tag_tuple_pattern<'a>(
231222
name: &'a str,
232223
arguments: &'a [CallArg<TypedPattern>],

0 commit comments

Comments
 (0)