renamed guard_clause in clause_guard and typos

Signed-off-by: Courtcircuits <[email protected]>

Author: Courtcircuits

compiler-core/src/parse.rs

@@ -1625,16 +1625,16 @@ where
         let Some((start, end)) = self.maybe_one(&Token::If) else {
             return Ok(None);
         };
-        let guard_clause_result = self.parse_clause_guard_inner();
-        // if inner clause is none, a warning should be thrown to prevent that this behaviour
-        // is deprecated
-        if let Ok(None) = guard_clause_result {
+        let clause_guard_result = self.parse_clause_guard_inner();
+        // If inner clause is none, a warning should be shown to let the user
+        // know that empty clauses in guards are deprecated.
+        if let Ok(None) = clause_guard_result {
             self.warnings
-                .push(DeprecatedSyntaxWarning::DeprecatedEmptyGuardClause {
+                .push(DeprecatedSyntaxWarning::DeprecatedEmptyClauseGuard {
                     location: SrcSpan { start, end },
                 });
         }
-        guard_clause_result
+        clause_guard_result
     }
 
     fn parse_clause_guard_inner(&mut self) -> Result<Option<UntypedClauseGuard>, ParseError> {

compiler-core/src/type_/tests/snapshots/gleam_core__type___tests__warnings__empty_guard_clause.snap

@@ -14,13 +14,11 @@ pub fn main() {
 }
 
 ----- WARNING
-warning: Deprecated empty guard clause syntax
+warning: Deprecated empty guard syntax
   ┌─ test/path:5:12
   │
 5 │         10 if -> True
-  │            ^^ This should be followed by a guard or removed!!
+  │            ^^ This can be removed.
 
-
-Empty clause within a guard is deprecated.
-To keep its behaviour, either remove the guard or fill the clause with
-`True` instead.
+This syntax for an empty guard is deprecated. To have a clause without a
+guard, remove this.

compiler-core/src/warning.rs

@@ -246,10 +246,10 @@ pub enum DeprecatedSyntaxWarning {
     /// ```gleam
     /// case wibble {
     ///     big if -> True
-    ///         ^^ this should be followed by a guard or removed!!
+    ///         ^^ This can be removed.
     /// }
     /// ```
-    DeprecatedEmptyGuardClause {
+    DeprecatedEmptyClauseGuard {
         location: SrcSpan,
     },
 
@@ -369,19 +369,20 @@ To match on all possible lists, use the `_` catch-all pattern instead.",
             Warning::DeprecatedSyntax {
                 path,
                 src,
-                warning: DeprecatedSyntaxWarning::DeprecatedEmptyGuardClause { location },
+                warning: DeprecatedSyntaxWarning::DeprecatedEmptyClauseGuard { location },
             } => Diagnostic {
-                title: "Deprecated empty guard clause syntax".into(),
+                title: "Deprecated empty guard syntax".into(),
                 text: wrap(
-                    "Empty clause within a guard is deprecated.
-To keep its behaviour, either remove the guard or fill the clause with `True` instead.",
+                    "This syntax for an empty guard is deprecated. \
+To have a clause without a guard, remove this.",
                 ),
                 hint: None,
                 level: diagnostic::Level::Warning,
                 location: Some(Location {
                     label: diagnostic::Label {
-                        text: Some("This should be followed by a guard or removed!!
-".into()),
+                        text: Some(
+                            "This can be removed.".into(),
+                        ),
                         span: *location,
                     },
                     path: path.clone(),