trigger the inline variable code action when over the let keyword as well

Author: giacomocavalieri

compiler-core/src/language_server/code_action.rs

@@ -6226,6 +6226,31 @@ impl<'a> InlineVariable<'a> {
 }
 
 impl<'ast> ast::visit::Visit<'ast> for InlineVariable<'ast> {
+    fn visit_typed_assignment(&mut self, assignment: &'ast TypedAssignment) {
+        let TypedPattern::Variable { location, name, .. } = &assignment.pattern else {
+            ast::visit::visit_typed_assignment(self, assignment);
+            return;
+        };
+
+        // We special case assignment variables because we want to trigger the
+        // code action also if we're over the let keyword:
+        //
+        // ```gleam
+        //    let wibble = 11
+        // // ^^^^^^^^^^ Here!
+        // ```
+        //
+        let assignment_range = self
+            .edits
+            .src_span_to_lsp_range(SrcSpan::new(assignment.location.start, location.end));
+        if !within(self.params.range, assignment_range) {
+            ast::visit::visit_typed_assignment(self, assignment);
+            return;
+        }
+
+        self.maybe_inline(*location, name.clone());
+    }
+
     fn visit_typed_expr_var(
         &mut self,
         location: &'ast SrcSpan,

compiler-core/src/language_server/tests/action.rs

@@ -8321,6 +8321,20 @@ pub fn main(x) {
     );
 }
 
+#[test]
+fn inline_variable_when_over_let_keyword() {
+    assert_code_action!(
+        INLINE_VARIABLE,
+        r#"
+pub fn main() {
+  let x = 123
+  x + 1
+}
+"#,
+        find_position_of("let").to_selection()
+    );
+}
+
 #[test]
 fn no_code_action_to_inline_variable_used_multiple_times() {
     let src = r#"

compiler-core/src/language_server/tests/snapshots/gleam_core__language_server__tests__action__inline_variable_when_over_let_keyword.snap

@@ -0,0 +1,18 @@
+---
+source: compiler-core/src/language_server/tests/action.rs
+expression: "\npub fn main() {\n  let x = 123\n  x + 1\n}\n"
+---
+----- BEFORE ACTION
+
+pub fn main() {
+  let x = 123
+  ↑          
+  x + 1
+}
+
+
+----- AFTER ACTION
+
+pub fn main() {
+  123 + 1
+}