Fix renaming variables in record updates

Author: GearsDatapacks

CHANGELOG.md

@@ -272,3 +272,7 @@
 
 - Fixed a bug where `echo .. as ..` message will be omitted in browser target.
   ([Andrey Kozhev](https://github.com/ankddev))
+
+- Fixed a bug where renaming a variable used in a record update would produce
+  invalid code in certain situations.
+  ([Surya Rose](https://github.com/GearsDatapacks))

compiler-core/src/language_server/reference.rs

@@ -400,10 +400,16 @@ impl<'ast> Visit<'ast> for FindVariableReferences {
                 location: definition_location,
                 ..
             } if definition_location == self.definition_location => {
-                self.references.push(VariableReference {
-                    location: *location,
-                    kind: VariableReferenceKind::Variable,
-                })
+                if !self
+                    .references
+                    .iter()
+                    .any(|reference| reference.location == *location)
+                {
+                    self.references.push(VariableReference {
+                        location: *location,
+                        kind: VariableReferenceKind::Variable,
+                    })
+                }
             }
             _ => {}
         }

compiler-core/src/language_server/tests/rename.rs

@@ -1550,3 +1550,20 @@ pub const something = 10
         find_position_of("something")
     );
 }
+
+#[test]
+fn rename_variable_used_in_record_update() {
+    assert_rename!(
+        "
+type Wibble {
+  Wibble(a: Int, b: Int, c: Int)
+}
+
+fn wibble(wibble: Wibble) {
+  Wibble(..wibble, c: 1)
+}
+",
+        "value",
+        find_position_of("wibble:")
+    );
+}

compiler-core/src/language_server/tests/snapshots/gleam_core__language_server__tests__rename__rename_variable_used_in_record_update.snap.new

@@ -0,0 +1,29 @@
+---
+source: compiler-core/src/language_server/tests/rename.rs
+assertion_line: 1556
+expression: "\ntype Wibble {\n  Wibble(a: Int, b: Int, c: Int)\n}\n\nfn wibble(wibble: Wibble) {\n  Wibble(..wibble, c: 1)\n}\n"
+snapshot_kind: text
+---
+----- BEFORE RENAME
+-- app.gleam
+
+type Wibble {
+  Wibble(a: Int, b: Int, c: Int)
+}
+
+fn wibble(wibble: Wibble) {
+          ↑▔▔▔▔▔           
+  Wibble(..wibble, c: 1)
+}
+
+
+----- AFTER RENAME
+-- app.gleam
+
+type Wibble {
+  Wibble(a: Int, b: Int, c: Int)
+}
+
+fn wibble(value: Wibble) {
+  Wibble(..value, c: 1)
+}