Skip to content

Commit f9fd43e

Browse files
vshakitskiylpil
authored andcommitted
apply changes
1 parent a69ab68 commit f9fd43e

File tree

4 files changed

+37
-3
lines changed

4 files changed

+37
-3
lines changed

compiler-cli/src/dependencies.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ mod dependency_manager;
33
use std::{
44
cell::RefCell,
55
collections::{HashMap, HashSet},
6-
io::Write,
76
process::Command,
87
rc::Rc,
98
time::Instant,
@@ -111,7 +110,7 @@ fn get_manifest_details(paths: &ProjectPaths) -> Result<(PackageConfig, Manifest
111110
Ok((config, manifest))
112111
}
113112

114-
fn list_manifest_packages<W: Write>(mut buffer: W, manifest: Manifest) -> Result<()> {
113+
fn list_manifest_packages<W: std::io::Write>(mut buffer: W, manifest: Manifest) -> Result<()> {
115114
manifest
116115
.packages
117116
.into_iter()
@@ -122,7 +121,7 @@ fn list_manifest_packages<W: Write>(mut buffer: W, manifest: Manifest) -> Result
122121
})
123122
}
124123

125-
fn list_package_and_dependencies_tree<W: Write>(
124+
fn list_package_and_dependencies_tree<W: std::io::Write>(
126125
mut buffer: W,
127126
options: TreeOptions,
128127
packages: Vec<ManifestPackage>,
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
source: compiler-cli/src/dependencies/tests.rs
3+
expression: output
4+
---
5+
Package Current Latest
6+
gleam_stdlib v0.45.0 v0.46.0
7+
very_long_package_name v12.12.12 v120.12.12
8+
wisp v2.1.0 v2.1.1

compiler-cli/src/dependencies/tests.rs

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,3 +1348,27 @@ fn test_pretty_print_major_versions_available() {
13481348

13491349
insta::assert_snapshot!(output);
13501350
}
1351+
1352+
#[test]
1353+
fn test_pretty_print_version_updates() {
1354+
let versions = vec![
1355+
(
1356+
"gleam_stdlib".to_string(),
1357+
(Version::new(0, 45, 0), Version::new(0, 46, 0)),
1358+
),
1359+
(
1360+
"wisp".to_string(),
1361+
(Version::new(2, 1, 0), Version::new(2, 1, 1)),
1362+
),
1363+
(
1364+
"very_long_package_name".to_string(),
1365+
(Version::new(12, 12, 12), Version::new(120, 12, 12)),
1366+
),
1367+
]
1368+
.into_iter()
1369+
.collect();
1370+
1371+
let output = pretty_print_version_updates(versions);
1372+
1373+
insta::assert_snapshot!(output);
1374+
}

compiler-core/src/dependency.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ fn resolve_versions_diffs(
8484
.filter(|version| !version.is_pre())
8585
.max()?;
8686

87+
// If we're checking for major version updates, only include the
88+
// package if a new major version is available. Otherwise, include
89+
// the package if there is any new version available.
8790
match check_major_versions {
8891
true => {
8992
if latest.major <= version.major {

0 commit comments

Comments
 (0)