Code action to generate new type

[giacomocavalieri]

The language server already allows to create new functions when needed. It would be nice if it allowed to do the same thing with types too. For example:

type Wibble {
  Wibble(Wobble)
//       ^^^^^^ Doesn't exist, trigger code action
}

type Wibble {
  Wibble(Wobble)
}

+ type Wobble

[giacomocavalieri]

I've started having a look at this internally and it seems like we don't carry around enough information in the typed ast to tell if a written type (a TypeAst) could be resolved to a type or resulted in an error. Do you think we should change it to carry around its type as well like the typed/untyped versions?

// Something like this, each variant of the TypeAst could 
// hold onto a reference to its type
type UntypedTypeAst = TypeAst<()>
type TypedTypeAst = TypeAst<Arc<Type>>
type TypeAst<Type> {

+  type_: Type
}

[lpil]

Seems somewhat redundant to me.

Why is it that we would need that information in the type AST? Doesn't the error contain all the required information (that it's an unknown type, what it is called, what module it is referenced in)? I guess it would need the number of parameters too, but that's all I think?

[giacomocavalieri]

Oh yeah totally I just didn't think of that! 😂