-
-
Notifications
You must be signed in to change notification settings - Fork 894
Bump pubgrub. #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pubgrub. #4480
Conversation
36dc047 to
3e10ecf
Compare
|
I have published the new package as v4! |
@lpil nice :D I rebased and tested the changes. |
lpil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful!! Thank you! I've left a couple notes inline
9cf1c55 to
2241987
Compare
lpil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for this. I just published that new hexpm package, is there a small upgrade to do in this PR now that can be used?
|
@lpil Thank you; I have used the hexpm update to avoid a call to clone :D |
|
Some linter issues to resolve! |
This commit updates the pubgrub and hexpm dependency version. It also makes sure that version ranges are parsed on creation rather than use to improve error handling.
lpil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bravo!! Thank you very much!
This PR requires gleam-lang/hexpm-rust#43. Create a symlink named hexpm in the root of the project linking to my
hexpm-rustbranch to look at my changes.Cargo.tomlneeds to be cleaned before a merge.Most changes are one of these three types of changes:
hexpm-rustchange that parseshexpm::version::Range.pubgrub::DependencyProvidertrait.Out of those, I believe nr. 3 warrants the most explanation (2. is explained in the
hexpm-rustpull request -- let me know if anything is unclear). The major changes includechoose_package_versionofpubgrub::DependencyProviderbeing split into the functionschoose_versionandprioritize, and the trait requiring the the associated typeErr: Error + 'static. The changes to thechoose_package_version, might be the hardest one to get correct, but all tests are passing so I think we are good. The change to the associatedErrtype required a new error type and caused this to propagate a bit. I don't know if this is the best way to do it, but it does the job :DAgain: Let me know if anything is unclear or if you want me to write a more detailed changelog.