update deserialising to use String instead of &str

Author: giacomocavalieri

src/lib.rs

@@ -849,8 +849,8 @@ fn deserialize_checksum<'de, D>(deserializer: D) -> Result<Vec<u8>, D::Error>
 where
     D: serde::Deserializer<'de>,
 {
-    let s: &str = serde::de::Deserialize::deserialize(deserializer)?;
-    base16::decode(s).map_err(serde::de::Error::custom)
+    let s: String = serde::de::Deserialize::deserialize(deserializer)?;
+    base16::decode(s.as_str()).map_err(serde::de::Error::custom)
 }
 
 impl<Meta> Release<Meta> {
@@ -885,8 +885,8 @@ impl<'de> serde::Deserialize<'de> for RetirementReason {
     where
         D: serde::Deserializer<'de>,
     {
-        let s: &str = serde::de::Deserialize::deserialize(deserializer)?;
-        match s {
+        let s: String = serde::de::Deserialize::deserialize(deserializer)?;
+        match s.as_str() {
             "other" => Ok(RetirementReason::Other),
             "invalid" => Ok(RetirementReason::Invalid),
             "security" => Ok(RetirementReason::Security),

src/version.rs

@@ -153,8 +153,8 @@ impl<'de> Deserialize<'de> for Version {
     where
         D: Deserializer<'de>,
     {
-        let s: &str = Deserialize::deserialize(deserializer)?;
-        Version::try_from(s).map_err(de::Error::custom)
+        let s: String = Deserialize::deserialize(deserializer)?;
+        Version::try_from(s.as_str()).map_err(de::Error::custom)
     }
 }
 
@@ -286,8 +286,8 @@ impl<'de> Deserialize<'de> for Range {
     where
         D: Deserializer<'de>,
     {
-        let s: &str = Deserialize::deserialize(deserializer)?;
-        Range::new(s.to_string()).map_err(serde::de::Error::custom)
+        let s: String = Deserialize::deserialize(deserializer)?;
+        Range::new(s).map_err(serde::de::Error::custom)
     }
 }
 

src/version/lexer.rs

@@ -122,7 +122,7 @@ pub struct Lexer<'input> {
 
 impl<'input> Lexer<'input> {
     /// Construct a new lexer for the given input.
-    pub fn new(input: &str) -> Lexer {
+    pub fn new(input: &str) -> Lexer<'_> {
         let mut chars = input.char_indices();
         let c1 = chars.next();
         let c2 = chars.next();
@@ -263,7 +263,7 @@ impl<'input> Iterator for Lexer<'input> {
 mod tests {
     use super::*;
 
-    fn lex(input: &str) -> Vec<Token> {
+    fn lex(input: &str) -> Vec<Token<'_>> {
         Lexer::new(input).map(Result::unwrap).collect::<Vec<_>>()
     }