add tests for get_repository_versions_data & get_package_data

Author: benev0

src/lib.rs

@@ -754,6 +754,10 @@ impl ApiError {
     pub fn is_not_found(&self) -> bool {
         matches!(self, Self::NotFound)
     }
+
+    pub fn is_invalid_protobuf(&self) -> bool {
+        matches!(self, Self::InvalidProtobuf(_))
+    }
 }
 
 /// Read a body and ensure it has the given sha256 digest.

src/tests.rs

@@ -1,7 +1,7 @@
 // TODO: remove all the async stuff and mockito server. The library is pure now
 // so it isn't needed.
 
-use std::convert::TryFrom;
+use std::{convert::TryFrom, io::Cursor};
 
 use super::*;
 use mockito::Matcher;
@@ -801,6 +801,116 @@ async fn publish_docs_forbidden() {
     mock.assert();
 }
 
+fn expected_package_exfmt() -> Package {
+    Package {
+        name: "exfmt".to_string(),
+        repository: "hexpm".to_string(),
+        releases: vec![
+            Release {
+                version: Version::try_from("0.0.0").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    82, 48, 191, 145, 92, 172, 0, 108, 238, 71, 57, 23, 101, 177, 161, 83, 91,
+                    182, 18, 232, 249, 225, 29, 12, 246, 5, 215, 165, 32, 57, 179, 110
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.1.0").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    111, 246, 240, 176, 118, 229, 12, 15, 164, 61, 186, 3, 89, 106, 153, 225,
+                    247, 52, 245, 8, 216, 139, 21, 232, 200, 16, 214, 59, 241, 188, 9, 6
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.2.0").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    149, 9, 192, 229, 84, 162, 110, 207, 161, 43, 31, 0, 126, 168, 14, 243, 31,
+                    43, 195, 238, 100, 91, 78, 100, 213, 181, 101, 154, 106, 168, 170, 107
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.2.1").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    157, 229, 28, 212, 92, 249, 14, 240, 235, 104, 31, 12, 160, 199, 83, 195,
+                    154, 105, 222, 37, 221, 80, 181, 183, 113, 240, 234, 107, 144, 85, 255, 65
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.2.2").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    112, 250, 133, 189, 183, 192, 54, 218, 115, 55, 216, 97, 204, 201, 191,
+                    168, 250, 133, 138, 252, 202, 240, 74, 197, 228, 235, 81, 18, 241, 7, 155,
+                    38
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.2.3").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    131, 20, 29, 160, 171, 124, 7, 125, 210, 88, 17, 189, 199, 49, 191, 190,
+                    14, 162, 38, 247, 52, 176, 189, 17, 7, 188, 151, 152, 24, 64, 170, 29
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.2.4").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    109, 162, 185, 169, 26, 4, 62, 60, 167, 54, 182, 161, 140, 197, 75, 113,
+                    183, 117, 247, 201, 218, 228, 14, 160, 115, 157, 196, 51, 108, 16, 96, 217
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.3.0").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    97, 50, 95, 212, 242, 59, 245, 177, 140, 78, 79, 180, 108, 174, 119, 176,
+                    24, 80, 218, 152, 178, 227, 152, 242, 32, 126, 72, 67, 222, 0, 173, 170
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.4.0").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    246, 178, 237, 214, 217, 158, 143, 52, 130, 186, 64, 50, 94, 175, 161, 81,
+                    68, 186, 4, 73, 53, 226, 235, 144, 209, 84, 231, 136, 165, 119, 122, 126
+                ],
+                meta: (),
+            },
+            Release {
+                version: Version::try_from("0.5.0").unwrap(),
+                requirements: [].into(),
+                retirement_status: None,
+                outer_checksum: vec![
+                    151, 86, 157, 218, 218, 131, 240, 119, 198, 216, 202, 240, 65, 17, 57, 228,
+                    84, 252, 59, 207, 246, 49, 22, 21, 52, 47, 51, 139, 190, 9, 95, 109
+                ],
+                meta: (),
+            }
+        ],
+    }
+}
+
 #[tokio::test]
 async fn get_package_ok_test() {
     let response_body = std::include_bytes!("../test/package_exfmt");
@@ -828,113 +938,7 @@ async fn get_package_ok_test() {
     .unwrap();
 
     assert_eq!(
-        Package {
-            name: "exfmt".to_string(),
-            repository: "hexpm".to_string(),
-            releases: vec![
-                Release {
-                    version: Version::try_from("0.0.0").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        82, 48, 191, 145, 92, 172, 0, 108, 238, 71, 57, 23, 101, 177, 161, 83, 91,
-                        182, 18, 232, 249, 225, 29, 12, 246, 5, 215, 165, 32, 57, 179, 110
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.1.0").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        111, 246, 240, 176, 118, 229, 12, 15, 164, 61, 186, 3, 89, 106, 153, 225,
-                        247, 52, 245, 8, 216, 139, 21, 232, 200, 16, 214, 59, 241, 188, 9, 6
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.2.0").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        149, 9, 192, 229, 84, 162, 110, 207, 161, 43, 31, 0, 126, 168, 14, 243, 31,
-                        43, 195, 238, 100, 91, 78, 100, 213, 181, 101, 154, 106, 168, 170, 107
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.2.1").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        157, 229, 28, 212, 92, 249, 14, 240, 235, 104, 31, 12, 160, 199, 83, 195,
-                        154, 105, 222, 37, 221, 80, 181, 183, 113, 240, 234, 107, 144, 85, 255, 65
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.2.2").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        112, 250, 133, 189, 183, 192, 54, 218, 115, 55, 216, 97, 204, 201, 191,
-                        168, 250, 133, 138, 252, 202, 240, 74, 197, 228, 235, 81, 18, 241, 7, 155,
-                        38
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.2.3").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        131, 20, 29, 160, 171, 124, 7, 125, 210, 88, 17, 189, 199, 49, 191, 190,
-                        14, 162, 38, 247, 52, 176, 189, 17, 7, 188, 151, 152, 24, 64, 170, 29
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.2.4").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        109, 162, 185, 169, 26, 4, 62, 60, 167, 54, 182, 161, 140, 197, 75, 113,
-                        183, 117, 247, 201, 218, 228, 14, 160, 115, 157, 196, 51, 108, 16, 96, 217
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.3.0").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        97, 50, 95, 212, 242, 59, 245, 177, 140, 78, 79, 180, 108, 174, 119, 176,
-                        24, 80, 218, 152, 178, 227, 152, 242, 32, 126, 72, 67, 222, 0, 173, 170
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.4.0").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        246, 178, 237, 214, 217, 158, 143, 52, 130, 186, 64, 50, 94, 175, 161, 81,
-                        68, 186, 4, 73, 53, 226, 235, 144, 209, 84, 231, 136, 165, 119, 122, 126
-                    ],
-                    meta: (),
-                },
-                Release {
-                    version: Version::try_from("0.5.0").unwrap(),
-                    requirements: [].into(),
-                    retirement_status: None,
-                    outer_checksum: vec![
-                        151, 86, 157, 218, 218, 131, 240, 119, 198, 216, 202, 240, 65, 17, 57, 228,
-                        84, 252, 59, 207, 246, 49, 22, 21, 52, 47, 51, 139, 190, 9, 95, 109
-                    ],
-                    meta: (),
-                }
-            ],
-        },
+        expected_package_exfmt(),
         package,
     );
 
@@ -959,6 +963,38 @@ async fn get_package_not_found() {
     assert!(error.is_not_found());
 }
 
+#[tokio::test]
+async fn get_package_from_bytes_ok() {
+    let response_body = std::include_bytes!("../test/package_exfmt");
+    let mut uncompressed = Vec::new();
+    let mut decoder = GzDecoder::new(Cursor::new(response_body));
+    let _ = decoder.read_to_end(&mut uncompressed).expect("failed to decompress body");
+
+    let package = crate::get_package_data(
+        &uncompressed,
+        std::include_bytes!("../test/public_key")
+    )
+    .expect("package failed to parse");
+
+    assert_eq!(
+        expected_package_exfmt(),
+        package,
+    );
+}
+
+#[tokio::test]
+async fn get_package_from_bytes_malformed() {
+    // public key should not be a valid protobuf and should therefore fail
+    let bytes = std::include_bytes!("../test/public_key").to_vec();
+    let package_error = crate::get_package_data(
+        &bytes,
+        &bytes,
+    )
+    .expect_err("parsing failed to fail");
+
+    assert!(package_error.is_invalid_protobuf());
+}
+
 #[tokio::test]
 async fn get_repository_versions_ok_test() {
     let response_body = std::include_bytes!("../test/versions");
@@ -1003,6 +1039,49 @@ async fn get_repository_versions_ok_test() {
     mock.assert();
 }
 
+#[tokio::test]
+async fn get_repository_versions_from_bytes_ok() {
+    let response_body = std::include_bytes!("../test/versions");
+    let mut uncompressed = Vec::new();
+    let mut decoder = GzDecoder::new(Cursor::new(response_body));
+    let _ = decoder.read_to_end(&mut uncompressed).expect("failed to decompress body");
+
+    let versions = crate::get_repository_versions_data(
+        &uncompressed,
+        std::include_bytes!("../test/public_key"),
+    )
+    .expect("versions failed to parse");
+
+    assert_eq!(
+        &vec![
+            Version::parse("0.0.0").unwrap(),
+            Version::parse("0.1.0").unwrap(),
+            Version::parse("0.2.0").unwrap(),
+            Version::parse("0.2.1").unwrap(),
+            Version::parse("0.2.2").unwrap(),
+            Version::parse("0.2.3").unwrap(),
+            Version::parse("0.2.4").unwrap(),
+            Version::parse("0.3.0").unwrap(),
+            Version::parse("0.4.0").unwrap(),
+            Version::parse("0.5.0").unwrap(),
+        ],
+        versions.get("exfmt").unwrap(),
+    );
+}
+
+#[tokio::test]
+async fn get_repository_versions_from_bytes_malformed() {
+    // public key should not be a valid protobuf and should therefore fail
+    let bytes = std::include_bytes!("../test/public_key").to_vec();
+    let versions_error = crate::get_repository_versions_data(
+        &bytes,
+        &bytes,
+    )
+    .expect_err("parsing failed to fail");
+
+    assert!(versions_error.is_invalid_protobuf());
+}
+
 #[tokio::test]
 async fn get_repository_tarball_ok_test() {
     let config = Config::new();