Skip to content

Conversation

@Kaholaz
Copy link
Contributor

@Kaholaz Kaholaz commented Apr 12, 2025

This bump changes the packages public API. This is mostly due to the implementation beeing a bit leaky. If you are unhappy with the changes, I can prioritize stability over ease of implementation. The major changes are mostly due to the change in the pubgrub::DependencyProvider trait that got overhauled pretty majorly.

@Kaholaz Kaholaz changed the title WIP: bump pubgrub version. Bump pubgrub version. Apr 14, 2025
This bump introduces some minor, backwards incompatible changes to the
public API. This is mostly because we expose parts of the pubgrub API
that now has been pretty majorly overhauled.
@Kaholaz
Copy link
Contributor Author

Kaholaz commented Apr 14, 2025

I would like a confirmation that pre-releases are handled correctly: basically, they are prioritized last. Any non-pre-release version is chosen before a pre-release. Is this correct, or should a pre-release version only be picked when referenced explicitly?

@Kaholaz Kaholaz marked this pull request as draft April 16, 2025 19:18
@lpil
Copy link
Member

lpil commented Apr 18, 2025

Hey hey! Thank you for this.

Have you got a branch for gleam-lang/gleam with this new version? We'll need to be sure everything works there before we can commit to releasing these changes.

I think @giacomocavalieri looked into this also, so I'd like his feedback.

I would like a confirmation that pre-releases are handled correctly: basically, they are prioritized last. Any non-pre-release version is chosen before a pre-release.

That's right 👍

@Kaholaz
Copy link
Contributor Author

Kaholaz commented Apr 18, 2025

Have you got a branch for gleam-lang/gleam with this new version? We'll need to be sure everything works there before we can commit to releasing these changes.

@lpil This is underway and is why I changed the status of this PR to draft. As I worked with integrating this with gleam, I discovered that gleam does not rely on this package for resolution. To not make this package and gleam drift in features, I am leaning on scrapping package-resolution from this package. I will update this when I am done with the gleam-lang integration -- hopefully later this evening.

@Kaholaz
Copy link
Contributor Author

Kaholaz commented Apr 19, 2025

superseded by #43

@Kaholaz Kaholaz closed this Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants