fix bug in persistent-hash-map.mjs

schurhammer · lpil · commit 6cf471534917 · 2023-04-10T10:29:34.000+01:00
missing check for key equality in the find function
diff --git a/src/persistent-hash-map.mjs b/src/persistent-hash-map.mjs
@@ -581,10 +581,13 @@ function findArray(root, shift, hash, key) {
   if (node === undefined) {
     return undefined;
   }
-  if (node.type === ENTRY) {
+  if (node.type !== ENTRY) {
+    return find(node, shift + SHIFT, hash, key);
+  }
+  if (isEqual(key, node.k)) {
     return node;
   }
-  return find(node, shift + SHIFT, hash, key);
+  return undefined;
 }
 /**
  * @template K,V

Original file line number	Diff line number	Diff line change
`@@ -581,10 +581,13 @@ function findArray(root, shift, hash, key) {`
`581`	`581`	`if (node === undefined) {`
`582`	`582`	`return undefined;`
`583`	`583`	`}`
`584`		`- if (node.type === ENTRY) {`
	`584`	`+ if (node.type !== ENTRY) {`
	`585`	`+ return find(node, shift + SHIFT, hash, key);`
	`586`	`+ }`
	`587`	`+ if (isEqual(key, node.k)) {`
`585`	`588`	`return node;`
`586`	`589`	`}`
`587`		`- return find(node, shift + SHIFT, hash, key);`
	`590`	`+ return undefined;`
`588`	`591`	`}`
`589`	`592`	`/**`
`590`	`593`	`* @template K,V`