Skip to content

Commit 934f181

Browse files
committed
Split test, remove extra function
1 parent 4a08ef5 commit 934f181

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

β€Žsrc/gleam/regex.gleam

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ pub fn scan(with regex: Regex, content string: String) -> List(Match) {
191191
@external(javascript, "../gleam_stdlib.mjs", "regex_scan")
192192
fn do_scan(a: Regex, b: String) -> List(Match)
193193

194-
/// Creates a new `String` by replacing all substrings that match the regular expression.
194+
/// Creates a new `String` by replacing all substrings that match the regular
195+
/// expression.
195196
///
196197
/// ## Examples
197198
///
@@ -206,14 +207,10 @@ fn do_scan(a: Regex, b: String) -> List(Match)
206207
/// replace(each: re, in: "a,b-c d+e", with: "/")
207208
/// // -> "a/b/c/d/e"
208209
/// `
210+
@external(erlang, "gleam_stdlib", "regex_replace")
211+
@external(javascript, "../gleam_stdlib.mjs", "regex_replace")
209212
pub fn replace(
210213
each pattern: Regex,
211214
in string: String,
212215
with substitute: String,
213-
) -> String {
214-
do_replace(pattern, string, substitute)
215-
}
216-
217-
@external(erlang, "gleam_stdlib", "regex_replace")
218-
@external(javascript, "../gleam_stdlib.mjs", "regex_replace")
219-
fn do_replace(a: Regex, b: String, c: String) -> String
216+
) -> String

β€Žtest/gleam/regex_test.gleam

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,16 +162,26 @@ pub fn scan_test() {
162162
|> should.equal([])
163163
}
164164

165-
pub fn replace_test() {
165+
pub fn replace_0_test() {
166166
let assert Ok(re) = regex.from_string(",")
167167
regex.replace(in: "a,b,c,d", each: re, with: " ")
168168
|> should.equal("a b c d")
169+
}
169170

171+
pub fn replace_1_test() {
170172
let assert Ok(re) = regex.from_string("\\d")
171173
regex.replace(in: "Hell1o, World!1", each: re, with: "")
172174
|> should.equal("Hello, World!")
175+
}
173176

177+
pub fn replace_2_test() {
174178
let assert Ok(re) = regex.from_string("🐈")
175179
regex.replace(in: "🐈🐈 are great!", each: re, with: "πŸ•")
176180
|> should.equal("πŸ•πŸ• are great!")
177181
}
182+
183+
pub fn replace_3_test() {
184+
let assert Ok(re) = regex.from_string("🐈")
185+
regex.replace(re, "🐈🐈 are great!", "πŸ•")
186+
|> should.equal("πŸ•πŸ• are great!")
187+
}

0 commit comments

Comments
Β (0)