Inspect bit strings

Author: lpil

src/gleam_stdlib.erl

@@ -337,35 +337,34 @@ inspect(Any) when is_integer(Any) ->
     erlang:integer_to_list(Any);
 inspect(Any) when is_float(Any) ->
     io_lib_format:fwrite_g(Any);
-inspect(Any) when is_binary(Any) ->
-    Pattern = [$"],
-    Replacement = [$\\, $\\, $"],
-    Escaped = re:replace(Any, Pattern, Replacement, [{return, binary}, global]),
-    ["\"", Escaped, "\""];
-inspect(Any) when is_list(Any) ->
-    ["[",
-        lists:join(<<", ">>,
-            lists:map(fun inspect/1, Any)
-        ),
-    "]"];
+inspect(Binary) when is_binary(Binary) ->
+    case gleam@bit_string:is_utf8(Binary) of
+        true ->
+            Pattern = [$"],
+            Replacement = [$\\, $\\, $"],
+            Escaped = re:replace(Binary, Pattern, Replacement, [{return, binary}, global]),
+            ["\"", Escaped, "\""];
+        false ->
+            Segments = [erlang:integer_to_list(X) || <<X>> <= Binary],
+            ["<<", lists:join(", ", Segments), ">>"]
+    end;
+inspect(List) when is_list(List) ->
+    Elements = lists:join(<<", ">>, lists:map(fun inspect/1, List)),
+    ["[", Elements, "]"];
 inspect(Any) when is_tuple(Any) % Record constructors
   andalso is_atom(element(1, Any))
   andalso element(1, Any) =/= false
   andalso element(1, Any) =/= true
   andalso element(1, Any) =/= nil
 ->
     [Atom | ArgsList] = erlang:tuple_to_list(Any),
-    Args =
-        lists:join(<<", ">>,
-            lists:map(fun inspect/1, ArgsList)
+    Args = lists:join(<<", ">>,
+        lists:map(fun inspect/1, ArgsList)
     ),
     [inspect(Atom), "(", Args, ")"];
-inspect(Any) when is_tuple(Any) ->
-    ["#(",
-        lists:join(<<", ">>,
-            lists:map(fun inspect/1, erlang:tuple_to_list(Any))
-        ),
-    ")"];
+inspect(Tuple) when is_tuple(Tuple) ->
+    Elements = lists:map(fun inspect/1, erlang:tuple_to_list(Tuple)),
+    ["#(", lists:join(", ", Elements), ")"];
 inspect(Any) when is_function(Any) ->
     {arity, Arity} = erlang:fun_info(Any, arity),
     ArgsAsciiCodes = lists:seq($a, $a + Arity - 1),

test/gleam/string_test.gleam

@@ -700,6 +700,9 @@ pub fn inspect_test() {
 
   string.inspect(InspectTypeOne(InspectTypeZero))
   |> should.equal("InspectTypeOne(InspectTypeZero)")
+
+  string.inspect(<<255, 2, 0>>)
+  |> should.equal("<<255, 2, 0>>")
 }
 
 if javascript {