Merge pull request #230 from gleanwork/codex/hjdivad/fix-getoauthscopes-to-include-offline_access

Fix Azure OAuth support

Author: david-hamilton-glean

packages/mcp-server-utils/src/auth/auth.ts

@@ -691,9 +691,13 @@ async function pollForToken(
 /**
  * Returns the OAuth scopes we need for the issuer.
  *
- * This will always include "openid profile" but some providers may need other
- * scopes to make the user email available.  We require the user email for the
- * token to be valid.
+ * In general this is "openid profile offline_access", but some providers may
+ * require different scopes for idiosyncratic reasons.
+ * 
+ * We require two things that are driven by scopes:
+ *
+ *  - user email (openid profile)
+ *  - refresh tokens (offline_access)
  */
 export function getOAuthScopes(config: GleanOAuthConfig): string {
   const { issuer: issuer } = config;
@@ -707,7 +711,7 @@ export function getOAuthScopes(config: GleanOAuthConfig): string {
     case 'okta.com':
       return 'openid profile offline_access';
     default:
-      return 'openid profile';
+      return 'openid profile offline_access';
   }
 }
 

packages/mcp-server-utils/src/test/auth/auth.test.ts

@@ -658,7 +658,9 @@ describe('auth', () => {
         authType: 'oauth' as const,
         baseUrl: 'https://api.example.com',
       };
-      expect(getOAuthScopes(config)).toMatchInlineSnapshot(`"openid profile"`);
+      expect(getOAuthScopes(config)).toMatchInlineSnapshot(
+        `"openid profile offline_access"`,
+      );
     });
   });