Skip to content

Commit 427ffcc

Browse files
authored
Make sure cell clicked fires in accordance with its documentation
1 parent e9b3f4e commit 427ffcc

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/data-editor/data-editor.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,11 +330,9 @@ const DataEditorImpl: React.ForwardRefRenderFunction<DataEditorRef, DataEditorPr
330330
data: !c.data,
331331
});
332332
setForceDraw(cv => (cv + 1) % 100); // I can't do math with triple digits so I always avoid it
333-
} else {
334-
onCellClicked?.([col - rowMarkerOffset, row]);
335333
}
336334
},
337-
[getMangedCellContent, mangledOnCellEdited, onCellClicked, rowMarkerOffset, gridSelection]
335+
[getMangedCellContent, mangledOnCellEdited, gridSelection]
338336
);
339337

340338
const focusOnRowFromTrailingBlankRow = React.useCallback(
@@ -597,8 +595,9 @@ const DataEditorImpl: React.ForwardRefRenderFunction<DataEditorRef, DataEditorPr
597595
if (col === selectedCol && col === prevCol && row === selectedRow && row === prevRow) {
598596
reselect(args.bounds);
599597
}
598+
onCellClicked?.([args.location[0] - rowMarkerOffset, args.location[1]])
600599
},
601-
[gridSelection, onHeaderClicked, reselect, rowMarkerOffset]
600+
[gridSelection, onCellClicked, onHeaderClicked, reselect, rowMarkerOffset]
602601
);
603602

604603
const onHeaderMenuClickInner = React.useCallback(

0 commit comments

Comments
 (0)