Skip to content

Commit dbc1963

Browse files
mmargaryanSassoun Derderian
authored andcommitted
fix: replace mousedown with pointerdown in click outside container
1 parent c961675 commit dbc1963

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

packages/core/src/internal/click-outside-container/click-outside-container.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ export default class ClickOutsideContainer extends React.PureComponent<Props> {
1313
public componentDidMount() {
1414
const eventTarget = this.props.customEventTarget ?? document;
1515
eventTarget.addEventListener("touchend", this.clickOutside, true);
16-
eventTarget.addEventListener("mousedown", this.clickOutside, true);
16+
eventTarget.addEventListener("pointerdown", this.clickOutside, true);
1717
eventTarget.addEventListener("contextmenu", this.clickOutside, true);
1818
}
1919

2020
public componentWillUnmount() {
2121
const eventTarget = this.props.customEventTarget ?? document;
2222
eventTarget.removeEventListener("touchend", this.clickOutside, true);
23-
eventTarget.removeEventListener("mousedown", this.clickOutside, true);
23+
eventTarget.removeEventListener("pointerdown", this.clickOutside, true);
2424
eventTarget.removeEventListener("contextmenu", this.clickOutside, true);
2525
}
2626

packages/core/test/data-editor.test.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
prep,
2525
sendClick,
2626
sendTouchClick,
27+
sendPointerClick,
2728
getCellCenterPositionForDefaultGrid,
2829
Context,
2930
standardBeforeEach,
@@ -1585,7 +1586,7 @@ describe("data-editor", () => {
15851586
const overlay = screen.getByDisplayValue("j");
15861587
expect(document.body.contains(overlay)).toBe(true);
15871588

1588-
sendClick(canvas, {
1589+
sendPointerClick(canvas, {
15891590
clientX: 300, // Col B
15901591
clientY: 36 + 32 * 5 + 16, // Row 1 (0 indexed)
15911592
});

packages/core/test/test-utils.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,14 @@ export function sendTouchClick(el: Element | Node | Document | Window, options?:
4646
});
4747
}
4848

49+
export function sendPointerClick(el: Element | Node | Document | Window, options?: any): void {
50+
fireEvent.pointerDown(el, options);
51+
52+
fireEvent.pointerUp(el, options);
53+
54+
fireEvent.click(el, options);
55+
}
56+
4957
export const makeCell = (cell: Item): GridCell => {
5058
const [col, row] = cell;
5159
switch (col) {

0 commit comments

Comments
 (0)