fix(effect-schema): validate boolean strings

Author: schani

packages/quicktype-core/src/language/TypeScriptEffectSchema/TypeScriptEffectSchemaRenderer.ts

@@ -100,7 +100,11 @@ export class TypeScriptEffectSchemaRenderer extends ConvenienceRenderer {
         return ["S.optional(", this.typeMapTypeFor(p.type), ")"];
     }
 
-    private typeMapTypeFor(t: Type, required = true): Sourcelike {
+    private typeMapTypeFor(
+        t: Type,
+        required = true,
+        coerceStrings = false,
+    ): Sourcelike {
         if (t.kind === "class" || t.kind === "object" || t.kind === "enum") {
             const name = this.nameForNamedType(t);
             if (this.emittedObjects.has(name)) {
@@ -143,6 +147,7 @@ export class TypeScriptEffectSchemaRenderer extends ConvenienceRenderer {
             (_enumType) => panic("Should already be handled."),
             (unionType) => {
                 const types = Array.from(unionType.getChildren());
+                const coerce = types.some((type) => type.kind === "bool");
                 const rank = (type: Type): number =>
                     type.kind === "class" || type.kind === "object" ? 1 : 0;
                 types.sort((a, b) => rank(a) - rank(b));
@@ -152,7 +157,7 @@ export class TypeScriptEffectSchemaRenderer extends ConvenienceRenderer {
                     if (type.kind === "null") {
                         nullable = true;
                     } else {
-                        children.push(this.typeMapTypeFor(type, false));
+                        children.push(this.typeMapTypeFor(type, false, coerce));
                     }
                 }
 
@@ -167,6 +172,10 @@ export class TypeScriptEffectSchemaRenderer extends ConvenienceRenderer {
                 ];
             },
             (_transformedStringType) => {
+                if (_transformedStringType.kind === "bool-string")
+                    return coerceStrings
+                        ? 'S.transform(S.Literal("true", "false"), S.Boolean, { strict: true, decode: (value) => value === "true", encode: (value) => value ? "true" : "false" })'
+                        : 'S.Literal("true", "false")';
                 return "S.String";
             },
         );

packages/quicktype-core/src/language/TypeScriptEffectSchema/language.ts

@@ -5,6 +5,7 @@ import {
     type IntegerRange,
 } from "../../support/IntegerRange.js";
 import { TargetLanguage } from "../../TargetLanguage.js";
+import type { StringTypeMapping } from "../../Type/TypeBuilderUtils.js";
 import type { LanguageName, RendererOptions } from "../../types.js";
 
 import { TypeScriptEffectSchemaRenderer } from "./TypeScriptEffectSchemaRenderer.js";
@@ -26,6 +27,10 @@ export class TypeScriptEffectSchemaTargetLanguage extends TargetLanguage<
         return JS_SAFE_INTEGER_RANGE;
     }
 
+    public get stringTypeMapping(): StringTypeMapping {
+        return new Map([["bool-string", "bool-string"]]) as StringTypeMapping;
+    }
+
     public constructor() {
         super(typeScriptEffectSchemaLanguageConfig);
     }

test/languages.ts

@@ -1692,6 +1692,7 @@ export const TypeScriptEffectSchemaLanguage: Language = {
         "integer",
         "strict-optional",
         "minmaxitems",
+        "bool-string",
     ],
     output: "TopLevel.ts",
     topLevel: "TopLevel",