Support more

Author: schani

debug-properties.test.ts

@@ -62,10 +62,10 @@
     "if-then-else|validate against correct branch, then vs else|invalid through else",
     "if-then-else|validate against correct branch, then vs else|invalid through then",
     "infinite-loop-detection|evaluating the same schema location against the same data location twice is not a sign of an infinite loop|failing case",
+    "not|collect annotations inside a 'not', even if collection is disabled|unevaluated property",
     "items|items and subitems|too many sub-items",
     "items|items and subitems|wrong item",
     "items|items and subitems|wrong sub-item",
-    "not|collect annotations inside a 'not', even if collection is disabled|unevaluated property",
     "ref|$id must be resolved against nearest parent, not just immediate parent|non-number is invalid",
     "ref|empty tokens in $ref json-pointer|non-number is invalid",
     "vocabulary|schema that uses custom metaschema with with no validation vocabulary|no validation: invalid number, but it still validates",
@@ -82,16 +82,9 @@
     "patternProperties|patternProperties with boolean schemas|object with property matching schema false is invalid",
     "patternProperties|regexes are not anchored by default and are case sensitive|recognized members are accounted for",
     "patternProperties|regexes are not anchored by default and are case sensitive|regexes are case sensitive, 2",
-    "prefixItems|a schema given for prefixItems|wrong types",
-    "prefixItems|prefixItems with boolean schemas|array with two items is invalid",
-    "properties|object properties validation|both properties invalid is invalid",
-    "properties|object properties validation|one property invalid is invalid",
     "properties|properties whose names are Javascript object property names|__proto__ not valid",
     "properties|properties whose names are Javascript object property names|constructor not valid",
     "properties|properties whose names are Javascript object property names|toString not valid",
-    "properties|properties with boolean schema|both properties present is invalid",
-    "properties|properties with boolean schema|only 'false' property present is invalid",
-    "properties|properties with escaped characters|object with strings is invalid",
     "properties|properties, patternProperties, additionalProperties interaction|additionalProperty invalidates others",
     "properties|properties, patternProperties, additionalProperties interaction|patternProperty invalidates nonproperty",
     "properties|properties, patternProperties, additionalProperties interaction|patternProperty invalidates property",

failing-tests-skip-list.json

@@ -59,10 +59,17 @@ export class ObjectPropertiesHandler implements RefinementHandler {
                 // Apply properties constraint
                 if (objectSchema.properties) {
                     for (const [propName, propSchema] of Object.entries(objectSchema.properties)) {
-                        if (Object.prototype.hasOwnProperty.call(value, propName) && propSchema !== undefined) {
-                            const zodPropSchema = convertJsonSchemaToZod(propSchema);
-                            if (!zodPropSchema.safeParse(value[propName]).success) {
-                                return false;
+                        if (propSchema !== undefined) {
+                            // Use a more robust way to check if property exists
+                            // This handles JavaScript special property names correctly
+                            const propExists = Object.getOwnPropertyDescriptor(value, propName) !== undefined;
+                            
+                            if (propExists) {
+                                const zodPropSchema = convertJsonSchemaToZod(propSchema);
+                                const propResult = zodPropSchema.safeParse(value[propName]);
+                                if (!propResult.success) {
+                                    return false;
+                                }
                             }
                         }
                     }
@@ -71,7 +78,9 @@ export class ObjectPropertiesHandler implements RefinementHandler {
                 // Apply required constraint
                 if (objectSchema.required && Array.isArray(objectSchema.required)) {
                     for (const requiredProp of objectSchema.required) {
-                        if (!Object.prototype.hasOwnProperty.call(value, requiredProp)) {
+                        // Use robust property detection for required props too
+                        const propExists = Object.getOwnPropertyDescriptor(value, requiredProp) !== undefined;
+                        if (!propExists) {
                             return false;
                         }
                     }