diff --git a/.drone.yml b/.drone.yml index cc1dc6c..47fad78 100644 --- a/.drone.yml +++ b/.drone.yml @@ -48,22 +48,6 @@ steps: - aws codeartifact login --tool pip --repository globality-pypi-local --domain globality --domain-owner $AWS_ACCOUNT_ID --region us-east-1 - ./entrypoint.sh test - - name: sonar-scanner - image: sonarsource/sonar-scanner-cli:latest - environment: - SONARQUBE_TOKEN: - from_secret: SONARQUBE_TOKEN - commands: - - >- - sonar-scanner - -Dsonar.login=$SONARQUBE_TOKEN - -Dsonar.projectBaseDir=/drone/src - -Dsonar.host.url=https://sonarqube.globality.cloud - -Dsonar.branch.name=${DRONE_BRANCH} - depends_on: - - lint-and-type-check - - test-py311-latest - - name: release-python-library-codeartifact image: python:3.11-slim environment: @@ -76,7 +60,8 @@ steps: EXTRA_INDEX_URL: from_secret: EXTRA_INDEX_URL depends_on: - - sonar-scanner + - lint-and-type-check + - test-py311-latest commands: - pip install -U pip==24.0 - pip install --quiet awscli twine==4.0.2 packaging==24.0 @@ -124,13 +109,6 @@ steps: commands: - echo "Dummy step to trigger dependency-validation" ---- -kind: secret -name: SONARQUBE_TOKEN -get: - path: secrets/dev/drone - name: DRONE_SONARQUBE_TOKEN - --- kind: secret name: AWS_ACCOUNT_ID diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml new file mode 100644 index 0000000..b6bc700 --- /dev/null +++ b/.github/workflows/codeql.yml @@ -0,0 +1,98 @@ +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. +# +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. +# +# ******** NOTE ******** +# We have attempted to detect the languages in your repository. Please check +# the `language` matrix defined below to confirm you have the correct set of +# supported CodeQL languages. +# +name: "CodeQL Advanced" + +on: + push: + branches: [ "master" ] + pull_request: + branches: [ "master" ] + schedule: + - cron: '12 15 * * 2' + +jobs: + analyze: + name: Analyze (${{ matrix.language }}) + # Runner size impacts CodeQL analysis time. To learn more, please see: + # - https://gh.io/recommended-hardware-resources-for-running-codeql + # - https://gh.io/supported-runners-and-hardware-resources + # - https://gh.io/using-larger-runners (GitHub.com only) + # Consider using larger runners or machines with greater resources for possible analysis time improvements. + runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} + permissions: + # required for all workflows + security-events: write + + # required to fetch internal or private CodeQL packs + packages: read + + # only required for workflows in private repositories + actions: read + contents: read + + strategy: + fail-fast: false + matrix: + include: + - language: python + build-mode: none + # CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'swift' + # Use `c-cpp` to analyze code written in C, C++ or both + # Use 'java-kotlin' to analyze code written in Java, Kotlin or both + # Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both + # To learn more about changing the languages that are analyzed or customizing the build mode for your analysis, + # see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning. + # If you are analyzing a compiled language, you can modify the 'build-mode' for that language to customize how + # your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + # Add any setup steps before running the `github/codeql-action/init` action. + # This includes steps like installing compilers or runtimes (`actions/setup-node` + # or others). This is typically only required for manual builds. + # - name: Setup runtime (example) + # uses: actions/setup-example@v1 + + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v3 + with: + languages: ${{ matrix.language }} + build-mode: ${{ matrix.build-mode }} + # If you wish to specify custom queries, you can do so here or in a config file. + # By default, queries listed here will override any specified in a config file. + # Prefix the list here with "+" to use these queries and those in the config file. + + # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs + queries: security-extended,security-and-quality + + # If the analyze step fails for one of the languages you are analyzing with + # "We were unable to automatically build your code", modify the matrix above + # to set the build mode to "manual" for that language. Then modify this step + # to build your code. + # ℹī¸ Command-line programs to run using the OS shell. + # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun + - if: matrix.build-mode == 'manual' + shell: bash + run: | + echo 'If you are using a "manual" build mode for one or more of the' \ + 'languages you are analyzing, replace this with the commands to build' \ + 'your code, for example:' + echo ' make bootstrap' + echo ' make release' + exit 1 + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v3 + with: + category: "/language:${{matrix.language}}" diff --git a/sonar-project.properties b/sonar-project.properties deleted file mode 100644 index 6b5d917..0000000 --- a/sonar-project.properties +++ /dev/null @@ -1,30 +0,0 @@ -# This file is auto generated with globality-build. -# You should not make any changes to this file manually -# -# See: http://github.com/globality-corp/globality-build - -sonar.organization=globality-corp -sonar.projectKey=globality-corp_openapi -sonar.projectName=openapi -sonar.github.repository=globality-corp/openapi -sonar.host.url=https://sonarqube.globality.cloud -sonar.python.version=3.11,3.12 -sonar.python.coverage.reportPaths=openapi/tests/coverage/cov.xml,openapi/tests/coverage/backwards-compat.xml,openapi/tests/coverage/daemon-contract.xml -sonar.python.xunit.reportPath=openapi/tests/test-results/pytest/junit.xml -sonar.exclusions=openapi/migrations/* -sonar.cpd.exclusions=openapi/tests/** - -# Excluded code smells -sonar.issue.ignore.multicriteria=empty1,define-const,test-class-name - -# Don't care about empty functions -sonar.issue.ignore.multicriteria.empty1.ruleKey=python:S1186 -sonar.issue.ignore.multicriteria.empty1.resourceKey=**/* - -# Don't care about define constant for duplicate strings in tests -sonar.issue.ignore.multicriteria.define-const.ruleKey=python:S1192 -sonar.issue.ignore.multicriteria.define-const.resourceKey=openapi/tests/** - -# Don't care about vars with ClassName formatting in tests -sonar.issue.ignore.multicriteria.test-class-name.ruleKey=python:S117 -sonar.issue.ignore.multicriteria.test-class-name.resourceKey=openapi/tests/**