Fix timer transfer name issue [#1206] (#1207)

Author: sirosen

changelog.d/20251118_125149_sirosen_main.md

@@ -0,0 +1,4 @@
+### Bugfixes
+
+* Fixed a bug in `globus timer create transfer` which caused the timer name to
+  be set incorrectly when filter rules are used.

src/globus_cli/commands/timer/create/transfer.py

@@ -249,8 +249,8 @@ def transfer_command(
     )
 
     for rule in filter_rules:
-        method, name = rule
-        transfer_data.add_filter_rule(method=method, name=name, type="file")
+        method, filter_name = rule
+        transfer_data.add_filter_rule(method=method, name=filter_name, type="file")
 
     if batch:
         add_batch_to_transfer_data(

tests/functional/timer/test_transfer_create.py

@@ -570,13 +570,16 @@ def test_timer_creation_supports_filter_rules(run_line, ep_for_timer):
         }
         for opt in filter_opts
     ]
+    name = "Awesome Timer"
 
     run_line(
         [
             "globus",
             "timer",
             "create",
             "transfer",
+            "--name",
+            name,
             "--stop-after-runs",
             "1",
             "--recursive",
@@ -587,5 +590,9 @@ def test_timer_creation_supports_filter_rules(run_line, ep_for_timer):
     )
 
     sent_data = json.loads(get_last_request().body)
-    transfer_body = sent_data["timer"]["body"]
+    timer_doc = sent_data["timer"]
+    transfer_body = timer_doc["body"]
+
+    # asserting the name is a regression test for #1206
+    assert timer_doc["name"] == name
     assert transfer_body["filter_rules"] == expected_filter_rules