Merge pull request #1120 from sirosen/fix-sgw-allowed-domains

sirosen · web-flow · commit f808941f7b78 · 2024-12-17T15:31:26.000-06:00
Bugfix: allow_domains vs allowed_domains
diff --git a/changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst b/changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst
@@ -0,0 +1,6 @@
+Fixed
+~~~~~
+
+- Fix a bug in ``StorageGatewayDocument`` which stored any ``allowed_domains``
+  argument under an ``"allow_domains"`` key instead of the correct key,
+  ``"allowed_domains"``. (:pr:`NUMBER`)
diff --git a/src/globus_sdk/services/gcs/data/storage_gateway.py b/src/globus_sdk/services/gcs/data/storage_gateway.py
@@ -78,7 +78,7 @@ def __init__(
             root=root,
         )
         self._set_optstrlists(
-            allow_domains=allowed_domains,
+            allowed_domains=allowed_domains,
             users_allow=users_allow,
             users_deny=users_deny,
         )

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ def __init__(`
`78`	`78`	`root=root,`
`79`	`79`	`)`
`80`	`80`	`self._set_optstrlists(`
`81`		`- allow_domains=allowed_domains,`
	`81`	`+ allowed_domains=allowed_domains,`
`82`	`82`	`users_allow=users_allow,`
`83`	`83`	`users_deny=users_deny,`
`84`	`84`	`)`