Skip to content

Commit 1fe075d

Browse files
committed
Fixed vector related crash on 4.4
1 parent 5e3c3af commit 1fe075d

File tree

8 files changed

+32
-13
lines changed

8 files changed

+32
-13
lines changed

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
def final VERSION_CODE = 2
2-
def final VERSION_NAME = '1.0.0-alpha2'
1+
def final VERSION_CODE = 3
2+
def final VERSION_NAME = '1.0.0-alpha3'
33

44
apply plugin: 'com.android.application'
55
apply plugin: 'kotlin-android'

app/src/main/kotlin/com/glodanif/bluetoothchat/activity/ChatActivity.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import android.content.Context
99
import android.content.Intent
1010
import android.os.Bundle
1111
import android.support.v7.app.AppCompatActivity
12+
import android.support.v7.app.AppCompatDelegate
1213
import android.support.v7.widget.LinearLayoutManager
1314
import android.support.v7.widget.RecyclerView
1415
import android.support.v7.widget.Toolbar
@@ -51,6 +52,7 @@ class ChatActivity : AppCompatActivity(), ChatView {
5152

5253
override fun onCreate(savedInstanceState: Bundle?) {
5354
super.onCreate(savedInstanceState)
55+
AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
5456
setContentView(R.layout.activity_chat)
5557
toolbar = findViewById<Toolbar>(R.id.toolbar)
5658
setSupportActionBar(toolbar)

app/src/main/kotlin/com/glodanif/bluetoothchat/activity/ConversationsActivity.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import android.content.Intent
1010
import android.os.Bundle
1111
import android.support.design.widget.FloatingActionButton
1212
import android.support.v7.app.AppCompatActivity
13+
import android.support.v7.app.AppCompatDelegate
1314
import android.support.v7.widget.LinearLayoutManager
1415
import android.support.v7.widget.RecyclerView
1516
import android.support.v7.widget.Toolbar
@@ -52,6 +53,7 @@ class ConversationsActivity : AppCompatActivity(), ConversationsView {
5253

5354
override fun onCreate(savedInstanceState: Bundle?) {
5455
super.onCreate(savedInstanceState)
56+
AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
5557
setContentView(R.layout.activity_conversations)
5658
val toolbar = findViewById<Toolbar>(R.id.toolbar)
5759
setSupportActionBar(toolbar)

app/src/main/kotlin/com/glodanif/bluetoothchat/activity/ProfileActivity.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import android.content.Intent
55
import android.support.v7.app.AppCompatActivity
66
import android.os.Bundle
77
import android.support.annotation.ColorInt
8+
import android.support.v7.app.AppCompatDelegate
89
import android.support.v7.widget.Toolbar
910
import android.view.MenuItem
1011
import android.view.View
@@ -39,6 +40,7 @@ class ProfileActivity : AppCompatActivity(), ProfileView {
3940

4041
override fun onCreate(savedInstanceState: Bundle?) {
4142
super.onCreate(savedInstanceState)
43+
AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
4244
setContentView(R.layout.activity_profile)
4345

4446
editMode = intent.getBooleanExtra(EXTRA_EDIT_MODE, false)

app/src/main/kotlin/com/glodanif/bluetoothchat/activity/ScanActivity.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import android.os.Bundle
1414
import android.support.v4.app.ActivityCompat
1515
import android.support.v4.content.ContextCompat
1616
import android.support.v7.app.AppCompatActivity
17+
import android.support.v7.app.AppCompatDelegate
1718
import android.support.v7.widget.LinearLayoutManager
1819
import android.support.v7.widget.RecyclerView
1920
import android.support.v7.widget.Toolbar
@@ -55,6 +56,7 @@ class ScanActivity : AppCompatActivity(), ScanView {
5556

5657
override fun onCreate(savedInstanceState: Bundle?) {
5758
super.onCreate(savedInstanceState)
59+
AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
5860
setContentView(R.layout.activity_scan)
5961
val toolbar = findViewById<Toolbar>(R.id.toolbar)
6062
setSupportActionBar(toolbar)

app/src/main/kotlin/com/glodanif/bluetoothchat/activity/SplashActivity.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@ package com.glodanif.bluetoothchat.activity
33
import android.os.Bundle
44
import android.os.Handler
55
import android.support.v7.app.AppCompatActivity
6+
import android.support.v7.app.AppCompatDelegate
67
import com.glodanif.bluetoothchat.R
78
import com.glodanif.bluetoothchat.model.SettingsManagerImpl
89

910
class SplashActivity: AppCompatActivity() {
1011

1112
override fun onCreate(savedInstanceState: Bundle?) {
1213
super.onCreate(savedInstanceState)
14+
AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
1315
setContentView(R.layout.activity_splash)
1416

1517
Handler().postDelayed({

app/src/main/kotlin/com/glodanif/bluetoothchat/widget/SettingsPopup.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ class SettingsPopup(context: Context) : PopupWindow() {
3838
private var container: View
3939
private var avatar: ImageView
4040
private var userNameLabel: TextView
41-
private var settingsButton: View
4241

4342
private var isDismissing: Boolean = false
4443

@@ -61,14 +60,13 @@ class SettingsPopup(context: Context) : PopupWindow() {
6160
container = rootView.findViewById(R.id.fl_container)
6261
avatar = rootView.findViewById<ImageView>(R.id.iv_avatar)
6362
userNameLabel = rootView.findViewById<TextView>(R.id.tv_username)
64-
settingsButton = rootView.findViewById(R.id.tv_settings_button)
6563

6664
rootView.findViewById<View>(R.id.ll_user_profile_container).setOnClickListener({
6765
dismiss()
6866
profileClickListener?.invoke()
6967
})
7068

71-
rootView.findViewById<View>(R.id.tv_settings_button).setOnClickListener({
69+
rootView.findViewById<View>(R.id.ll_settings_button).setOnClickListener({
7270
dismiss()
7371
settingsClickListener?.invoke()
7472
})

app/src/main/res/layout/popup_settings.xml

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:app="http://schemas.android.com/apk/res-auto"
34
xmlns:tools="http://schemas.android.com/tools"
45
android:id="@+id/fl_container"
56
android:layout_width="wrap_content"
@@ -51,21 +52,31 @@
5152
android:layout_height="1dp"
5253
android:background="@color/text_dark" />
5354

54-
<TextView
55-
android:id="@+id/tv_settings_button"
55+
<LinearLayout
56+
android:id="@+id/ll_settings_button"
5657
android:layout_width="match_parent"
5758
android:layout_height="wrap_content"
5859
android:background="?android:attr/selectableItemBackground"
5960
android:clickable="true"
60-
android:drawablePadding="8dp"
61-
android:drawableStart="@drawable/ic_settings_black_24dp"
6261
android:focusable="true"
6362
android:gravity="center_vertical"
64-
android:padding="12dp"
65-
android:text="@string/conversations__settings"
66-
android:textSize="16sp"
67-
android:textStyle="bold" />
63+
android:orientation="horizontal"
64+
android:padding="12dp">
65+
66+
<ImageView
67+
android:layout_width="24dp"
68+
android:layout_height="24dp"
69+
android:layout_marginEnd="8dp"
70+
app:srcCompat="@drawable/ic_settings_black_24dp" />
71+
72+
<TextView
73+
android:layout_width="match_parent"
74+
android:layout_height="wrap_content"
75+
android:text="@string/conversations__settings"
76+
android:textSize="16sp"
77+
android:textStyle="bold" />
6878

79+
</LinearLayout>
6980
</LinearLayout>
7081
</android.support.v7.widget.CardView>
7182
</FrameLayout>

0 commit comments

Comments
 (0)