🩹🚇 Fix CI (#13)

* 🩹🚇 Fix CI

* 🚧🧰 Add dependabot config

* 🧰 Add action lint to pre-commit

* 🩹🚇 Add back repo checkout in compare-results step

Author: s-weigand

.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+  # Maintain dependencies for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+      day: friday
+      time: "18:00"
+      timezone: Europe/Amsterdam

.github/workflows/run-tests.yml

@@ -16,15 +16,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.10"
 
       - name: Run pre-commit
-        uses: pre-commit/action@v3.0.0
+        uses: pre-commit/action@v3.0.1
 
   test-pyglotaran-examples:
     needs: [pre-commit]

.github/workflows/test-pyglotaran-examples.yml

@@ -9,10 +9,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout pyglotaran-validation
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Checkout compare results to comparison-results
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: "glotaran/pyglotaran-examples"
           ref: comparison-results
@@ -49,12 +49,12 @@ jobs:
         example_name: ${{fromJson(needs.create-example-list.outputs.example-list)}}
     steps:
       - name: Checkout pyglotaran main branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: "glotaran/pyglotaran"
 
       - name: Set up Python 3.10
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.10"
       - name: Install pyglotaran
@@ -75,34 +75,79 @@ jobs:
           pip freeze
 
       - name: Upload Example Plots Artifact
-        uses: actions/upload-artifact@v3
+        if: always()
+        uses: actions/upload-artifact@v4
         with:
-          name: example-plots
-          path: ${{ steps.example-run.outputs.plots-path }}
+          name: example-notebooks-${{ matrix.example_name }}
+          path: ${{ steps.example-run.outputs.notebook-path }}
 
       - name: Upload Example Results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: example-results
+          name: example-results-${{ matrix.example_name }}
           path: ~/pyglotaran_examples_results
 
+  collect-artifacts:
+    if: always()
+    name: "Collect artifacts and reupload as bundle"
+    runs-on: ubuntu-latest
+    needs: [run-examples]
+    steps:
+      - name: Download Notebooks Artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: example-notebooks
+          pattern: example-notebooks-*
+          merge-multiple: true
+
+      - name: Upload Example Notebooks Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: example-notebooks
+          path: example-notebooks
+          overwrite: true
+
+      - name: Delete Intermediate Notebooks artifacts
+        uses: GeekyEggo/delete-artifact@v5
+        with:
+          name: example-notebooks-*
+
+      - name: Download Result Artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: example-results
+          pattern: example-results-*
+          merge-multiple: true
+
+      - name: Upload Example Result Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: example-results
+          path: example-results
+          overwrite: true
+
+      - name: Delete Intermediate Result artifacts
+        uses: GeekyEggo/delete-artifact@v5
+        with:
+          name: example-results-*
+
   compare-results:
     name: Compare Results
     runs-on: ubuntu-latest
-    needs: [run-examples]
+    needs: [collect-artifacts]
     steps:
       - name: Checkout pyglotaran-validation
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Checkout compare results
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: "glotaran/pyglotaran-examples"
           ref: comparison-results
           path: comparison-results
 
       - name: Download result artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: example-results
           path: comparison-results-current
@@ -118,7 +163,7 @@ jobs:
           echo "::endgroup::"
 
       - name: Set up Python 3.10
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.10"
 

.pre-commit-config.yaml

@@ -42,3 +42,8 @@ repos:
     hooks:
       - id: codespell
         files: ".py|.rst"
+
+  - repo: https://github.com/rhysd/actionlint
+    rev: "v1.7.1"
+    hooks:
+      - id: actionlint