fix: Fix ToolBox UI html warnings

Author: g-bougard

share/html/toolbox/inventory-list.tpl

@@ -203,39 +203,39 @@ if (@jobs_order) {
               <div class='progress-col'>
                 <div class='counters-row'>
                   <div class='counter-cell'>
-                    <label>";
+                    <span>";
       if ($task->{islocal}) {
-        $OUT .= _("Local inventory")."</label>
+        $OUT .= _("Local inventory")."</span>
                   <div class='counters-row'>
                     <span class='counter' id='$taskid-inventory-count'>".($task->{inventory_count} || 0)."</span>
                   </div>
                 </div>";
       } else {
-        $OUT .= _("Created inventories")."</label>
+        $OUT .= _("Created inventories")."</span>
                   <div class='counters-row'>
                     <span class='counter' id='$taskid-inventory-count' title='"._("Should match devices with SNMP support count")."'>
                       ".($task->{inventory_count} || 0).($task->{inventory_count} && $task->{snmp_support} ? "/".$task->{snmp_support} : "")."
                     </span>
                   </div>
                 </div>
                 <div class='counter-cell'>
-                  <label>"._("Scanned IPs")."</label>
+                  <span>"._("Scanned IPs")."</span>
                   <div class='counters-row'>
                     <span class='counter' id='$taskid-scanned' title='"._("Scanned IPs for this IP range")."'>
                       ".($task->{count} || 0).($task->{count} && $task->{count} < $task->{maxcount} ? "/".$task->{maxcount} : "")."
                     </span>
                   </div>
                 </div>
                 <div class='counter-cell'>
-                  <label>"._("Devices with SNMP support")."</label>
+                  <span>"._("Devices with SNMP support")."</span>
                   <div class='counters-row'>
                     <span class='counter' id='$taskid-snmp' title='"._("IPs for which we found a device supporting SNMP with provided credentials")."'>
                       ".($task->{snmp_support} || 0).($task->{snmp_support} && $task->{count} ? "/".$task->{count} : "")."
                     </span>
                   </div>
                 </div>
                 <div class='counter-cell'>
-                  <label>"._("IPs without SNMP response")."</label>
+                  <span>"._("IPs without SNMP response")."</span>
                   <div class='counters-row'>
                     <span class='counter' id='$taskid-others' title='"._("These IPs are responding to ping or are found in ARP table")."\n".
                       _("But we didn't find any device supporting SNMP with provided credentials")."'>
@@ -244,7 +244,7 @@ if (@jobs_order) {
                   </div>
                 </div>
                 <div class='counter-cell'>
-                  <label>"._("IPs without PING response")."</label>
+                  <span>"._("IPs without PING response")."</span>
                   <div class='counters-row'>
                     <span class='counter' id='$taskid-unknown' title='"._("IPs not responding to ping and not seen in ARP table")."'>
                       ".($task->{unknown} || 0).($task->{unknown} && $task->{count} ? "/".$task->{count} : "")."

share/html/toolbox/list-navigation.tpl

@@ -25,7 +25,7 @@
       }</div>
       <div class='display-option list-option'>
         {_"Display (number of items)"}
-        <select class='display-option' onchange="document.getElementById('display').value = this.value; submit();">{
+        <select class='display-option' id='display-option' onchange="document.getElementById('display').value = this.value; submit();">{
         foreach my $opt (@display_options) {
           $OUT .= "
           <option".($display && $display eq $opt ? " selected" : "").

share/html/toolbox/results-list.tpl

@@ -3,19 +3,19 @@
     <div class='counter-cell' title='{_"Number of devices seen by network scan other all results"}
 {_"A seen device is identified by its IPs and tag"}
 {_"A local inventory can be included as seen if its IP has been scanned by a network scan task"}'>
-      <label>{_"IPs seen by Network Scan"}</label>
+      <span>{_"IPs seen by Network Scan"}</span>
       <div class='counters-row'>
         <span class='counter'>{$netscan_count}/{$list_count}</span>
       </div>
     </div>
     <div class='counter-cell' title='{_"Number of Network Inventory other all scanned IPs"}'>
-      <label>{_"Network Scan Inventory count"}</label>
+      <span>{_"Network Scan Inventory count"}</span>
       <div class='counters-row'>
         <span class='counter'>{$netscan_inventory_count}/{$list_count}</span>
       </div>
     </div>
     <div class='counter-cell' title='{_"Number of local inventory other all scanned IPs"}'>
-      <label>{_"Local Inventory count"}</label>
+      <span>{_"Local Inventory count"}</span>
       <div class='counters-row'>
         <span class='counter'>{$local_inventory_count}/{$list_count}</span>
       </div>

share/html/toolbox/toolbox.css

@@ -272,7 +272,7 @@ textarea {
   text-align: center;
 }
 
-.counter-cell label {
+.counter-cell span {
   font: bold 16px Arial, Helvetica;
 }