Skip to content

Commit 259ef0e

Browse files
authored
no empty find call in TilesManager (#23686)
1 parent 21712c6 commit 259ef0e

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/Glpi/Helpdesk/Tile/TilesManager.php

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,17 @@ public function getTilesForItem(
179179
*/
180180
public function getAllTiles(): array
181181
{
182+
global $DB;
183+
182184
// Load all tiles from the database
183185
$tiles = [];
184-
$item_tile = new Item_Tile();
185-
$item_tiles = $item_tile->find([], ['itemtype_item', 'items_id_item', 'rank']);
186+
$it = $DB->request([
187+
'SELECT' => ['itemtype_tile', 'items_id_tile'],
188+
'FROM' => Item_Tile::getTable(),
189+
'ORDER' => ['itemtype_item', 'items_id_item', 'rank'],
190+
]);
186191

187-
foreach ($item_tiles as $row) {
192+
foreach ($it as $row) {
188193
// Validate tile itemtype
189194
$itemtype = $row['itemtype_tile'];
190195
/** @var CommonDBTM $tile */
@@ -195,7 +200,7 @@ public function getAllTiles(): array
195200

196201
// Try to load tile from database
197202
try {
198-
if (!$tile->getFromDb($row['items_id_tile'])) {
203+
if (!$tile->getFromDB($row['items_id_tile'])) {
199204
continue;
200205
}
201206
} catch (InvalidTileException $e) {

0 commit comments

Comments
 (0)