Group Complete Name Display Error

[netsysspecialist-boop]

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Version

11.0.1

Bug description

Creating Multiple Groups ( Group 1 & Group 2 )& assigning it to one user.
Output: Two Groups were assigned, but display the same Complete Name( Group 1 & Group 1)

Relevant log output

Page URL

No response

Steps To reproduce

1. Create Groups > Group 1 & Group 2
2. Assign Group 1 to one User ( Reflects Group 1 )
3. Assign Group 2 to the same User ( Reflects Group 1 )

Your GLPI setup information

No response

Anything else?

No response

[cconard96]

Where is the display error ocurring? Is this the search results for the users?

[netsysspecialist-boop]

Yes, when viewing all users, then adding default items to show ( Groups ).

[cconard96]

I confirm the bug. The SQL query returns the correct results for the group column like "All Users$#$1$$##$$Admins$#$2", and the links in the displayed results actually go to the correct groups, but the names shown for each link are always the first group.

[cconard96]

Linked PR seems irrelevant. The reported issue was with the search results showing the first group's label for all of the user's groups even though the links were correct, not that the list in the User's Groups tab wasn't showing the completename.

Further, this issue has gotten worse since I originally tested. Now, only the first group shows at all and it isn't a link anymore.
#21510 seems to be causing an early return so the remaining groups are not processed and the itemlink handling isn't either.

[SebSept]

3 changes were introduced, one was for search results showing the first group's label for all of the user's groups as I remember, but maybe I'm wrong. I'll check.
The tabs were fixed by the way as I discovered them.

(I wish I could update the issue's description, with informations collected in answers, but I don't have that right) @cedric-anne

[cconard96]

Indeed, I missed your change to SQLProvider. It seems like it is just a regression from the PR I linked that needs fixed.
I'd say a test could be useful to detect regressions, but its something that should be done more globally (SQLProvider::giveItem probably has low test coverage) and tests already take too long.

[SebSept]

In fact, there were a misunderstanding, the displayed name was complete, but it was the first group repeated twice.

Sure, adding tests for giveItem is welcomed ! (but may be hard to write, since method is so big).

[SebSept]

Issue was resolved with the linked PR (#21486).
The issue seems to be reintroduced by #21510 (Curtis, reported above).