fix: number input doesn't send NaN values

lars-berger · lars-berger · commit 6bb70a136773 · 2024-12-09T04:58:47.000+08:00
diff --git a/src/components/number-input.tsx b/src/components/number-input.tsx
@@ -50,7 +50,7 @@ export function NumberInput(props: NumberInputProps) {
     >
       <_NumberField.Input
         placeholder={local.placeholder}
-        onChange={e => local.onChange?.(e.currentTarget.valueAsNumber)}
+        onChange={e => local.onChange?.(Number(e.currentTarget.value))}
         class={
           'flex h-9 w-full rounded-md border border-input bg-transparent px-3 py-1 text-left text-sm shadow-sm placeholder:text-muted-foreground focus-visible:outline-none disabled:cursor-not-allowed disabled:opacity-50'
         }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export function NumberInput(props: NumberInputProps) {`
`50`	`50`	`>`
`51`	`51`	`<_NumberField.Input`
`52`	`52`	`placeholder={local.placeholder}`
`53`		`- onChange={e => local.onChange?.(e.currentTarget.valueAsNumber)}`
	`53`	`+ onChange={e => local.onChange?.(Number(e.currentTarget.value))}`
`54`	`54`	`class={`
`55`	`55`	`'flex h-9 w-full rounded-md border border-input bg-transparent px-3 py-1 text-left text-sm shadow-sm placeholder:text-muted-foreground focus-visible:outline-none disabled:cursor-not-allowed disabled:opacity-50'`
`56`	`56`	`}`