perf: avoid redundant traversable check

Author: lars-berger

src/methods/get-field-error.ts

@@ -1,5 +1,4 @@
 import type { FormValue, FormState, FieldPath } from '../types';
-import { isTraversable } from '../utils';
 
 /**
  * Get the first error for a field (if there is one).
@@ -8,19 +7,15 @@ export function getFieldError<V extends FormValue, P extends FieldPath<V>>(
   formState: FormState<V>,
   fieldPath: P,
 ): string | null {
-  const { value: formValue } = formState;
   const { errorFieldPaths } = formState.__internal.fieldStates;
 
   if (errorFieldPaths.has(fieldPath)) {
     return errorFieldPaths.get(fieldPath)?.[0] ?? null;
   }
 
-  // No need to check descendants if the value is not an object or array.
-  if (isTraversable(formValue)) {
-    for (const [errorFieldPath, errors] of errorFieldPaths) {
-      if (errorFieldPath.startsWith(fieldPath)) {
-        return errors[0] ?? null;
-      }
+  for (const [errorFieldPath, errors] of errorFieldPaths) {
+    if (errorFieldPath.startsWith(fieldPath)) {
+      return errors[0] ?? null;
     }
   }
 

src/methods/get-field-errors.ts

@@ -1,5 +1,4 @@
 import type { FormValue, FormState, FieldPath } from '../types';
-import { isTraversable } from '../utils';
 
 /**
  * Get all errors for a field.
@@ -8,19 +7,15 @@ export function getFieldErrors<
   V extends FormValue,
   P extends FieldPath<V>,
 >(formState: FormState<V>, fieldPath: P): string[] {
-  const { value: formValue } = formState;
   const { errorFieldPaths } = formState.__internal.fieldStates;
 
   if (errorFieldPaths.has(fieldPath)) {
     return errorFieldPaths.get(fieldPath) ?? [];
   }
 
-  // No need to check descendants if the value is not an object or array.
-  if (isTraversable(formValue)) {
-    for (const [errorFieldPath, errors] of errorFieldPaths) {
-      if (errorFieldPath.startsWith(fieldPath)) {
-        return errors;
-      }
+  for (const [errorFieldPath, errors] of errorFieldPaths) {
+    if (errorFieldPath.startsWith(fieldPath)) {
+      return errors;
     }
   }
 

src/methods/is-field-dirty.ts

@@ -1,5 +1,4 @@
 import type { FieldPath, FormState, FormValue } from '../types';
-import { isTraversable } from '../utils';
 
 /**
  * Whether the form field is dirty.
@@ -15,19 +14,15 @@ export function isFieldDirty<V extends FormValue, P extends FieldPath<V>>(
   formState: FormState<V>,
   fieldPath: P,
 ): boolean {
-  const { value: formValue } = formState;
   const { dirtyFieldPaths } = formState.__internal.fieldStates;
 
   if (dirtyFieldPaths.has(fieldPath)) {
     return true;
   }
 
-  // No need to check descendants if the value is not an object or array.
-  if (isTraversable(formValue)) {
-    for (const dirtyFieldPath of dirtyFieldPaths) {
-      if (dirtyFieldPath.startsWith(fieldPath)) {
-        return true;
-      }
+  for (const dirtyFieldPath of dirtyFieldPaths) {
+    if (dirtyFieldPath.startsWith(fieldPath)) {
+      return true;
     }
   }
 

src/methods/is-field-touched.ts

@@ -1,5 +1,4 @@
 import type { FormValue, FormState, FieldPath } from '../types';
-import { isTraversable } from '../utils';
 
 /**
  * Whether the form field is touched.
@@ -15,19 +14,15 @@ export function isFieldTouched<
   V extends FormValue,
   P extends FieldPath<V>,
 >(formState: FormState<V>, fieldPath: P): boolean {
-  const { value: formValue } = formState;
   const { touchedFieldPaths } = formState.__internal.fieldStates;
 
   if (touchedFieldPaths.has(fieldPath)) {
     return true;
   }
 
-  // No need to check descendants if the value is not an object or array.
-  if (isTraversable(formValue)) {
-    for (const touchedFieldPath of touchedFieldPaths) {
-      if (touchedFieldPath.startsWith(fieldPath)) {
-        return true;
-      }
+  for (const touchedFieldPath of touchedFieldPaths) {
+    if (touchedFieldPath.startsWith(fieldPath)) {
+      return true;
     }
   }