Skip to content

Commit 052435c

Browse files
authored
Remove unnecessary @RequiresApi annotations in FlutterView.java (flutter#180051)
after flutter#175508 has Landed some of these warnings started to appear: <img width="471" height="234" alt="save_0" src="https://github.com/user-attachments/assets/f3ef3e61-861e-456e-a7ec-f2315db742bc" /> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] All existing and new tests are passing. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent c967b4d commit 052435c

File tree

1 file changed

+0
-3
lines changed
  • engine/src/flutter/shell/platform/android/io/flutter/embedding/android

1 file changed

+0
-3
lines changed

engine/src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,6 @@ private void resetWillNotDraw(boolean isAccessibilityEnabled, boolean isTouchExp
11121112

11131113
// -------- Start: Mouse -------
11141114
@Override
1115-
@RequiresApi(API_LEVELS.API_24)
11161115
@NonNull
11171116
public PointerIcon getSystemPointerIcon(int type) {
11181117
return PointerIcon.getSystemIcon(getContext(), type);
@@ -1150,7 +1149,6 @@ public void redispatch(@NonNull KeyEvent keyEvent) {
11501149
* <p>See {@link #detachFromFlutterEngine()} for information on how to detach from a {@link
11511150
* FlutterEngine}.
11521151
*/
1153-
@RequiresApi(API_LEVELS.API_24)
11541152
public void attachToFlutterEngine(@NonNull FlutterEngine flutterEngine) {
11551153
Log.v(TAG, "Attaching to a FlutterEngine: " + flutterEngine);
11561154
if (isAttachedToFlutterEngine()) {
@@ -1278,7 +1276,6 @@ public void attachToFlutterEngine(@NonNull FlutterEngine flutterEngine) {
12781276
* <p>See {@link #attachToFlutterEngine(FlutterEngine)} for information on how to attach a {@link
12791277
* FlutterEngine}.
12801278
*/
1281-
@RequiresApi(API_LEVELS.API_24)
12821279
public void detachFromFlutterEngine() {
12831280
Log.v(TAG, "Detaching from a FlutterEngine: " + flutterEngine);
12841281
if (!isAttachedToFlutterEngine()) {

0 commit comments

Comments
 (0)