Add field for udp_identifier, clean code

Author: gmlarumbe

grammar.js

@@ -2603,8 +2603,7 @@ const rules = {
 
 // ** A.5.4 UDP instantiation
   udp_instantiation: $ => seq(
-    // field('instance_type', $.udp_identifier), // TODO: For some reason results in parse errors with tree-sitter 0.22.6, in core/instantiation/user_defined_primitives
-    $.udp_identifier,
+    field('instance_type', $.udp_identifier),
     optional($.drive_strength),
     optional($.delay2),
     prec.dynamic(-1, commaSep1($.udp_instance)), // Give $.hierarchical_instance and $.module_instantiation higher priority
@@ -4002,7 +4001,7 @@ const rules = {
     $.cast,
     $.assignment_pattern_expression,
     $.streaming_concatenation,
-    // $.sequence_method_call, // TODO: Remove temporarily to narrow conflicts
+    // $.sequence_method_call, //  Remove to narrow conflicts
     'this',
     '$',
     'null',

src/grammar.json

@@ -77,7 +77,7 @@ endmodule
                 (hierarchical_identifier
                   (simple_identifier))))))))
     (udp_instantiation
-      (simple_identifier)
+      instance_type: (simple_identifier)
       (udp_instance
         (output_terminal
           (net_lvalue
@@ -93,7 +93,7 @@ endmodule
               (hierarchical_identifier
                 (simple_identifier)))))))
     (udp_instantiation
-      (simple_identifier)
+      instance_type: (simple_identifier)
       (drive_strength
         (strength0)
         (strength1))

src/node-types.json

@@ -20,7 +20,7 @@ endmodule
       (module_keyword)
       name: (simple_identifier))
     (udp_instantiation
-      (simple_identifier)
+      instance_type: (simple_identifier)
       (udp_instance
         (output_terminal
           (net_lvalue
@@ -36,7 +36,7 @@ endmodule
               (hierarchical_identifier
                 (simple_identifier)))))))
     (udp_instantiation
-      (simple_identifier)
+      instance_type: (simple_identifier)
       (drive_strength
         (strength0)
         (strength1))

src/parser.c

@@ -20,7 +20,7 @@ endmodule
       (module_keyword)
       name: (simple_identifier))
     (udp_instantiation
-      (simple_identifier)
+      instance_type: (simple_identifier)
       (drive_strength
         (strength1)
         (strength0))