Linting

Author: JustShah

Gemfile

@@ -21,7 +21,6 @@ gem 'pg', '~> 1.0', require: false if dbs.match?(/all|postgres/)
 gem 'fast_sqlite', require: false if dbs.match?(/all|sqlite/)
 gem 'sqlite3', '~> 1.4', require: false if dbs.match?(/all|sqlite/)
 
-
 gem 'database_cleaner', '~> 2.0', require: false
 gem 'rspec-activemodel-mocks', '~> 1.1', require: false
 gem 'rspec-rails', '~> 6.0.3', require: false

api/app/controllers/spree/api/line_items_controller.rb

@@ -49,7 +49,7 @@ def set_metadata(line_item)
        if can?(:admin, Spree::LineItem)
          line_item.update(admin_metadata: line_item_params[:admin_metadata])
        end
-     end
+      end
 
       def load_order
         @order ||= Spree::Order.includes(:line_items).find_by!(number: order_id)

api/spec/requests/spree/api/customer_returns_spec.rb

@@ -128,8 +128,7 @@ module Spree::Api
         put spree.api_order_customer_return_path(customer_return.order, customer_return.id),
         params: {
           order_id: customer_return.order.number,
-          customer_return: { stock_location_id: final_stock_location.id, admin_metadata: { 'order_number' => 'PN345678' }
-          }
+          customer_return: { stock_location_id: final_stock_location.id, admin_metadata: { 'order_number' => 'PN345678' } }
         }
 
         expect(response.status).to eq(200)

api/spec/requests/spree/api/line_items_spec.rb

@@ -111,8 +111,7 @@ module Spree::Api
         params: {
           line_item: { variant_id: product.master.to_param,
                        quantity: 1,
-                       customer_metadata: { "Company" => "Sample Company" }
-                      }
+                       customer_metadata: { "Company" => "Sample Company" } }
         }
 
         expect(json_response['customer_metadata']).to eq({ "Company" => "Sample Company" })

api/spec/requests/spree/api/orders_spec.rb

@@ -1010,7 +1010,7 @@ module Spree::Api
 
         it "can view admin_metadata" do
           get spree.api_order_path(order)
-          
+
           expect(json_response).to have_key('admin_metadata')
         end
       end

api/spec/requests/spree/api/payments_spec.rb

@@ -198,7 +198,7 @@ module Spree::Api
                   admin_metadata: { 'order_number' => 'PN345678' }
                 }
               }
-              
+
               expect(response.status).to eq(200)
               expect(json_response["admin_metadata"]).to eq({ 'order_number' => 'PN345678' })
             end

api/spec/requests/spree/api/shipments_spec.rb

@@ -102,7 +102,7 @@ module Spree::Api
         }
 
         put(spree.api_shipment_path(shipment), params:)
-        
+
         expect(response.status).to eq(200)
         expect(json_response['stock_location_name']).to eq(stock_location.name)
         expect(json_response["admin_metadata"]).to eq({ 'delivery_type' => 'express' })

api/spec/requests/spree/api/stock_locations_spec.rb

@@ -137,7 +137,7 @@ module Spree::Api
 
         it "can see admin metadata" do
           get spree.api_stock_location_path(stock_location)
-          
+
           expect(response).to be_successful
           expect(json_response).to have_key('admin_metadata')
         end

api/spec/requests/spree/api/stock_movements_spec.rb

@@ -94,7 +94,7 @@ module Spree::Api
         }
 
         post(spree.api_stock_location_stock_movements_path(stock_location), params:)
-        
+
         expect(response.status).to eq(201)
         expect(json_response).to have_attributes(attributes)
         expect(json_response["admin_metadata"]).to eq({ 'is_deadstock' => 'true' })

api/spec/requests/spree/api/users_spec.rb

@@ -214,7 +214,7 @@ module Spree::Api
 
       it "can update admin_metadata" do
         post spree.api_users_path, params: { user: { email: "existing@example.com", admin_metadata: { 'user_type' => 'regular' } } }
-        
+
         expect(json_response).to have_attributes(attributes)
         expect(response.status).to eq(201)
         expect(json_response["admin_metadata"]).to eq({ 'user_type' => 'regular' })