Update API to have firstname and lastname fields

Update the address handling logic in the APIs and tests to separate the 'firstname' and 'lastname' fields, instead of using a single 'name' field.

Author: JustShah

api/lib/spree/api_configuration.rb

@@ -61,7 +61,7 @@ class ApiConfiguration < Preferences::Configuration
     ]
 
     preference :address_attributes, :array, default: [
-      :id, :name, :address1, :address2, :city, :zipcode, :phone, :company,
+      :id, :firstname, :lastname, :address1, :address2, :city, :zipcode, :phone, :company,
       :alternative_phone, :country_id, :country_iso, :state_id, :state_name,
       :state_text
     ]

api/spec/requests/spree/api/address_books_spec.rb

@@ -7,7 +7,8 @@ module Spree::Api
     let!(:state) { create(:state) }
     let!(:harry_address_attributes) do
       {
-        'name' => 'Harry Potter',
+        'firstname' => 'Harry',
+        'lastname' => 'Potter',
         'address1' => '4 Privet Drive',
         'address2' => 'cupboard under the stairs',
         'city' => 'Surrey',
@@ -20,7 +21,8 @@ module Spree::Api
 
     let!(:ron_address_attributes) do
       {
-        'name' => 'Ron Weasly',
+        'firstname' => 'Ron',
+        'lastname' => 'Weasly',
         'address1' => 'Ottery St. Catchpole',
         'address2' => '4th floor',
         'city' => 'Devon, West Country',
@@ -53,7 +55,7 @@ module Spree::Api
         it 'updates my address book' do
           user = create(:user, spree_api_key: 'galleon')
           address = user.save_in_address_book(harry_address_attributes, true)
-          harry_address_attributes['name'] = 'Ron Weasly'
+          harry_address_attributes['firstname'] = 'Ron'
 
           expect {
             put "/api/users/#{user.id}/address_book",
@@ -73,7 +75,7 @@ module Spree::Api
 
         context "when updating a default address" do
           let(:user) { create(:user, spree_api_key: 'galleon') }
-          let(:changes) { { name: "Hermione Granger", id: user.ship_address.id} }
+          let(:changes) { { firstname: "Hermione", lastname: "Granger", id: user.ship_address.id} }
           before do
             # Create "Harry Potter" default shipping address
             user.save_in_address_book(harry_address_attributes, true)
@@ -168,7 +170,7 @@ module Spree::Api
         it "updates another user's address" do
           other_user = create(:user)
           address = other_user.save_in_address_book(harry_address_attributes, true)
-          updated_harry_address = harry_address_attributes.merge('name' => 'Ron Weasly')
+          updated_harry_address = harry_address_attributes.merge('firstname' => 'Ron')
 
           expect {
             put "/api/users/#{other_user.id}/address_book",

api/spec/requests/spree/api/checkouts_spec.rb

@@ -71,7 +71,8 @@ module Spree::Api
 
         let(:address) do
           {
-            name:  'John Doe',
+            firstname:  'John',
+            lastname:   'Doe',
             address1:   '7735 Old Georgetown Road',
             city:       'Bethesda',
             phone:      '3014445002',
@@ -94,8 +95,8 @@ module Spree::Api
               ship_address_attributes: address
             } }
           expect(json_response['state']).to eq('delivery')
-          expect(json_response['bill_address']['name']).to eq('John Doe')
-          expect(json_response['ship_address']['name']).to eq('John Doe')
+          expect(json_response['bill_address']['firstname']).to eq('John')
+          expect(json_response['ship_address']['firstname']).to eq('John')
           expect(response.status).to eq(200)
         end
 

api/spec/requests/spree/api/orders_spec.rb

@@ -531,12 +531,12 @@ module Spree::Api
 
       let(:address_params) { { country_id: country.id } }
       let(:billing_address) {
-        { name: "Tiago Motta", address1: "Av Paulista",
+        { firstname: "Tiago", lastname: "Motta", address1: "Av Paulista",
                                 city: "Sao Paulo", zipcode: "01310-300", phone: "12345678",
                                 country_id: country.id, state_id: state.id }
       }
       let(:shipping_address) {
-        { name: "Tiago Motta", address1: "Av Paulista",
+        {  firstname: "Tiago", lastname: "Motta", address1: "Av Paulista",
                                  city: "Sao Paulo", zipcode: "01310-300", phone: "12345678",
                                  country_id: country.id, state_id: state.id }
       }

api/spec/requests/spree/api/users_spec.rb

@@ -50,7 +50,8 @@ module Spree::Api
         put spree.api_user_path(user.id), params: { token: user.spree_api_key, user: {
           email: "mine@example.com",
           bill_address_attributes: {
-            name: 'First Last',
+            firstname: 'First',
+            lastname: 'Last',
             address1: '1 Test Rd',
             city: 'City',
             country_id: country.id,
@@ -59,7 +60,8 @@ module Spree::Api
             phone: '5555555555'
           },
           ship_address_attributes: {
-            name: 'First Last',
+            firstname: 'First',
+            lastname: 'Last',
             address1: '1 Test Rd',
             city: 'City',
             country_id: country.id,
@@ -83,7 +85,8 @@ module Spree::Api
             token: user.spree_api_key,
             email: "mine@example.com",
             bill_address_attributes: {
-              name: 'First Last',
+              firstname: 'First',
+              lastname: 'Last',
               address1: '1 Test Rd',
               city: 'City',
               country_id: country.id,
@@ -92,7 +95,8 @@ module Spree::Api
               phone: '5555555555'
             },
             ship_address_attributes: {
-              name: 'First Last',
+              firstname: 'First',
+              lastname: 'Last',
               address1: '1 Test Rd',
               city: 'City',
               country_id: country.id,