Fix Nerd Font Bundle not persisting after restart. Issue 12744

Fonts were downloaded to a temp directory and registered with
CTFontManagerRegisterFontDescriptors using persistent scope. However,
persistent scope only stores a reference to the font file location -
it doesn't copy the font data. When the temp directory was cleaned up,
the registration pointed to non-existent files.

Now copy fonts to ~/Library/Application Support/iTerm2/Fonts/ before
registering them, so they persist across sessions.

Author: gnachman

sources/NSFileManager+iTerm.h

@@ -58,6 +58,9 @@ extern NSNotificationName iTermScriptsFolderDidChange;
 - (NSString *)scriptsPathWithoutSpaces;
 - (BOOL)customScriptsFolderIsValid:(NSString *)candidate;
 
+// Directory where fonts installed by iTerm2 live (e.g., Nerd Font Bundle).
+- (NSString *)fontsDirectory;
+
 // Path to special auto-launch script that is run at startup.
 - (NSString *)legacyAutolaunchScriptPath;  // applescript
 - (NSString *)autolaunchScriptPath;  // scripting API

sources/NSFileManager+iTerm.m

@@ -259,6 +259,15 @@ - (NSString *)scriptsPathWithoutSpacesCreatingLink {
     return modernPath;
 }
 
+- (NSString *)fontsDirectory {
+    NSString *path = [[self applicationSupportDirectory] stringByAppendingPathComponent:@"Fonts"];
+    NSError *error = nil;
+    if (![self fileExistsAtPath:path]) {
+        [self createDirectoryAtPath:path withIntermediateDirectories:YES attributes:nil error:&error];
+    }
+    return path;
+}
+
 - (NSString *)legacyAutolaunchScriptPath {
     return [[self scriptsPath] stringByAppendingPathComponent:@"AutoLaunch.scpt"];
 }

sources/NerdFontInstaller.swift

@@ -200,10 +200,27 @@ class NerdFontInstaller {
         return Set(Array(fontCollection))
     }
 
+    private static var fontsDirectory: URL {
+        URL(fileURLWithPath: FileManager.default.fontsDirectory())
+    }
+
     private func install(from tempDir: String) {
         let fileManager = FileManager.default
+        let fontsDir = Self.fontsDirectory
+
+        // Copy fonts to permanent location and create descriptors from there
         let fontDescriptors = fileManager.flatMapRegularFiles(in: tempDir) { itemURL in
-            if let descriptors = CTFontManagerCreateFontDescriptorsFromURL(itemURL as CFURL) {
+            let destURL = fontsDir.appendingPathComponent(itemURL.lastPathComponent)
+            do {
+                if fileManager.fileExists(atPath: destURL.path) {
+                    try fileManager.removeItem(at: destURL)
+                }
+                try fileManager.copyItem(at: itemURL, to: destURL)
+            } catch {
+                DLog("Failed to copy font \(itemURL.lastPathComponent): \(error)")
+                return [CTFontDescriptor]()
+            }
+            if let descriptors = CTFontManagerCreateFontDescriptorsFromURL(destURL as CFURL) {
                 return Array<CTFontDescriptor>(descriptors)
             }
             return []